Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade nigoapi 0.1.0 #422

Merged
merged 7 commits into from
May 1, 2024
Merged

Upgrade nigoapi 0.1.0 #422

merged 7 commits into from
May 1, 2024

Conversation

juldrixx
Copy link
Contributor

@juldrixx juldrixx commented Apr 29, 2024

Q A
Bug fix? no
New feature? yes
API breaks? no
Deprecations? yes
Related tickets -
License Apache 2.0

What's in this PR?

Upgrade of NiGoApi from v0.0.10 to v0.1.0.

Why?

To use the latest API from NiFi 2.0.0-M2.

Checklist

  • Implementation tested
  • Error handling code meets the guideline
  • Logging code meets the guideline
  • User guide and development docs updated (if needed)
  • Append changelog with changes

@juldrixx juldrixx marked this pull request as ready for review April 29, 2024 12:37
@juldrixx
Copy link
Contributor Author

@mh013370 Should I remove MaximumEventDrivenThreadCount from v1 CRD or just do it like that?

@juldrixx juldrixx requested review from erdrix and mh013370 April 29, 2024 12:38
CHANGELOG.md Show resolved Hide resolved
@mh013370
Copy link
Member

@mh013370 Should I remove MaximumEventDrivenThreadCount from v1 CRD or just do it like that?

Removing it is a breaking change, but we could document that from nifikop v1.9.0+ it has no effect and will be removed in later CRD versions.

@mh013370
Copy link
Member

Is this update compatible with NiFi 1.x NiFi deployments? Or is this PR staged for 2.0?

@juldrixx
Copy link
Contributor Author

Is this update compatible with NiFi 1.x NiFi deployments? Or is this PR staged for 2.0?

Older version than 1.18 won't fully work. I tested in 1.16 and 1.17 and the operator can't create the registry client so it can't deploy dataflow from it but it can do the rest. And in >=1.18, it works fine. I can create user, group, parameter context, registry client, dataflow. I updated the documention to reflect it.

This was to be expected, as version 1.23 of the api ended up working with version 2.0.0-M2.

@juldrixx juldrixx requested a review from mh013370 April 30, 2024 10:09
Copy link
Member

@mh013370 mh013370 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for updating the compatibility matrix!

@juldrixx juldrixx merged commit d7ce7f4 into master May 1, 2024
5 checks passed
@juldrixx juldrixx deleted the upgrade_nigoapi_0.1.0 branch May 17, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants