-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade nigoapi 0.1.0 #422
Conversation
@mh013370 Should I remove |
Removing it is a breaking change, but we could document that from nifikop v1.9.0+ it has no effect and will be removed in later CRD versions. |
Is this update compatible with NiFi 1.x NiFi deployments? Or is this PR staged for 2.0? |
Older version than 1.18 won't fully work. I tested in 1.16 and 1.17 and the operator can't create the registry client so it can't deploy dataflow from it but it can do the rest. And in >=1.18, it works fine. I can create user, group, parameter context, registry client, dataflow. I updated the documention to reflect it. This was to be expected, as version 1.23 of the api ended up working with version 2.0.0-M2. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks for updating the compatibility matrix!
What's in this PR?
Upgrade of NiGoApi from v0.0.10 to v0.1.0.
Why?
To use the latest API from NiFi 2.0.0-M2.
Checklist