Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

certmanager-user: k8sutil: corrects IsAlreadyOwnedError #416

Merged

Conversation

mheers
Copy link
Contributor

@mheers mheers commented Apr 17, 2024

Q A
Bug fix? yes
New feature? no
API breaks? no
Deprecations? no
License Apache 2.0

What's in this PR?

The check, if an error is type of controllerutil.AlreadyOwnedError did not work. This PR fixes it.

Why?

The check, if an error is type of controllerutil.AlreadyOwnedError did not work. This PR fixes it.

Checklist

  • Implementation tested
  • Error handling code meets the guideline
  • Logging code meets the guideline
  • User guide and development docs updated (if needed)
  • Append changelog with changes

@mh013370
Copy link
Member

Can you remove the packaged *.tgz helm charts and update the .gitignore to ignore them going forward? :)

Copy link
Member

@mh013370 mh013370 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mh013370 mh013370 force-pushed the feature/fix-already-owned-error-check branch from e515cd8 to 95efbab Compare April 17, 2024 13:21
@mh013370
Copy link
Member

I rebased this branch to fix the govuln errors.

@mheers mheers force-pushed the feature/fix-already-owned-error-check branch from 95efbab to 8983912 Compare April 17, 2024 13:25
@mheers
Copy link
Contributor Author

mheers commented Apr 17, 2024

I also force pushed the branch again that also removed the .tgz files

@juldrixx juldrixx merged commit f4ce2cf into konpyutaika:master Apr 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants