adds security context for pod and its containers #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mh013370
reviewed
Mar 1, 2024
mh013370
reviewed
Mar 1, 2024
|
We need this too. Thanks. |
|
@mh013370 thanks for your review. Could you have a look again? |
|
We are really looking forward to this PR. |
|
Please update the CHANGELOG, following the existing convention to include your new feature. |
|
updated the CHANGELOG |
mh013370
force-pushed
the
feature/securitycontext
branch
from
e5aff09 to
4954ddd
Compare
|
Sorry one more thing I overlooked! Can you please add these new options to the docs? Then i should be good to merge. |
|
Added the docs. |
juldrixx
requested changes
Apr 18, 2024
|
Docs and CHANGELOG should now be corrected. |
|
This LGTM now. Just some CHANGELOG conflicts to resolve :) Thank you for this contribution! |
mh013370
approved these changes
Apr 19, 2024
juldrixx
requested changes
May 6, 2024
juldrixx
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Adds security context for pod and its containers.
Why?
To make nifi cluster pods compatible with e.g. kyverno we need to implement a few basic security measures like SecurityContext.
Checklist