Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propage WebProxyHosts update #392

Merged
merged 3 commits into from
Mar 13, 2024
Merged

Conversation

juldrixx
Copy link
Contributor

@juldrixx juldrixx commented Feb 16, 2024

Q A
Bug fix? no
New feature? yes
API breaks? no
Deprecations? no
Related tickets #390
License Apache 2.0

What's in this PR?

When the webProxyHosts of a NifiCluster is updated, the DNSNames of the node's NifiUsers are updated, and if the DNSNames of a NifiUser are updated, the associated Certificate is updated.

Why?

Because if we want to add a new host, if we don't update the certificate, the trustore won't be updated and the host won't be valid in NiFI.

Checklist

  • Implementation tested
  • Error handling code meets the guideline
  • Logging code meets the guideline
  • User guide and development docs updated (if needed)
  • Append changelog with changes

@juldrixx juldrixx requested review from erdrix and mh013370 February 16, 2024 13:34
@juldrixx juldrixx force-pushed the feat/propagate_webproxyhosts_update branch from 11c522b to 1f25b8d Compare February 16, 2024 13:37
Copy link
Contributor Author

@juldrixx juldrixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if I should pass the cluster information, because it can cause the restart of the cluster.

	if err = k8sutil.Reconcile(log, client, issuer, cluster, &cluster.Status); err != nil {
		return err
	}
        ...
	if err = k8sutil.Reconcile(log, client, issuer, cluster, &cluster.Status); err != nil {
		return err
	}
        ...
	if err = k8sutil.Reconcile(log, client, cert, cluster, &cluster.Status); err != nil {
		return err
	}
        ...
        if err = k8sutil.Reconcile(log, client, secret, cluster, &cluster.Status); err != nil {
		return err
	}
        ...
	if err = k8sutil.Reconcile(log, client, user, cluster, &cluster.Status); err != nil {
		return err
	}

@juldrixx juldrixx requested a review from mh013370 March 4, 2024 22:55
Copy link
Member

@mh013370 mh013370 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No major concerns after review

@juldrixx juldrixx merged commit 2be328d into master Mar 13, 2024
5 checks passed
@juldrixx juldrixx deleted the feat/propagate_webproxyhosts_update branch March 13, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants