-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to kubebuilder v4 #366
Conversation
43f3715
to
e1d04e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before taking an in-depth look and testing it, I think that the version of Operator SDK is mentionned in the documention (not sure for Kubebuilder itself), so it must be updated accordingly.
Yeah, so basically upgrading to operador-sdk v1.33.0 is just migrating to kubebuilder go/v4: https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.33.0/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial checks LGTM.
I'll test a few cluster deployments using this branch tomorrow 👍
I was thinking of NiFiKop documentation 😄 |
You're right it is. Updated :) |
2b7e960
to
e78ecbf
Compare
830a710
to
7634c53
Compare
migrate to kubebuilder go/v4
7634c53
to
aedb636
Compare
Co-authored-by: Juldrixx <[email protected]>
What's in this PR?
Migrates the operator to KubeBuilder go/v4 and operator-sdk v1.33.0, applying all appropriate migrations in the process. The migration process required re-scaffolding the entire API and all controllers in order to regenerate the
PROJECT
configuration, but the actual specs & controller code was copied forward. Regardless, care should be taken in reviewing this to ensure that i did not incidentally leave something out.I updated the
Makefile
and all generated Kustomize configuration to match the latest in KubeBuilder. From this point, only minor updates should be required.Primary changes:
main.go
moved tocmd/main.go
controllers/
moved tointernal/controller/
config/
generated yaml was updatedNote Merging this will necessitate updating your locally installed
operator-sdk
to v1.33.0.Why?
KubeBuilder go/v4 is now stable and go/v3 will be end-of-lifed and removed.
Checklist