Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set FlowRegistry type in RegistryClient creation #349

Merged
merged 3 commits into from
Jan 9, 2024

Conversation

juldrixx
Copy link
Contributor

@juldrixx juldrixx commented Jan 9, 2024

Q A
Bug fix? no
New feature? no
API breaks? no
Deprecations? no
Related tickets -
License Apache 2.0

What's in this PR?

Added the FlowRegistry type when creation a RegistryClient.

Why?

in 2.0.0-M1, the field seems to be mandatory.

Additional context

Tested in 2.0.0-M1 and 1.18.0.

Checklist

  • Implementation tested
  • Error handling code meets the guideline
  • Logging code meets the guideline
  • User guide and development docs updated (if needed)
  • Append changelog with changes

@juldrixx juldrixx requested review from erdrix and mh013370 January 9, 2024 10:10
@mh013370 mh013370 merged commit 0b856ec into master Jan 9, 2024
5 checks passed
@juldrixx juldrixx deleted the add_flow_registry_type branch May 17, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants