Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unschedule the whole dataflow in case of ParameterContext reference u… #340

Merged
merged 3 commits into from
Dec 19, 2023

Conversation

juldrixx
Copy link
Contributor

@juldrixx juldrixx commented Dec 19, 2023

…pdate

Q A
Bug fix? yes
New feature? no
API breaks? no
Deprecations? no
Related tickets -
License Apache 2.0

What's in this PR?

In case of parameter context reference update, the operator will now unschedule the entire dataflow (stop the processors and disable the controller services) instead of just stopping the processors.

Why?

When the parameter context was referenced by a controller service, it was impossible to change the reference because the operator could not detach the parameter context because it was in use.

Checklist

  • Implementation tested
  • Error handling code meets the guideline
  • Logging code meets the guideline
  • User guide and development docs updated (if needed)
  • Append changelog with changes

@juldrixx juldrixx merged commit 33cf42a into master Dec 19, 2023
5 checks passed
@juldrixx juldrixx deleted the fix/dataflow_parameter_context_ref_update branch December 19, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants