Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to configure network protocol and load balancer class for external service configs #335

Merged
merged 10 commits into from
Dec 14, 2023

Conversation

mh013370
Copy link
Member

@mh013370 mh013370 commented Dec 12, 2023

Q A
Bug fix? no
New feature? yes
API breaks? no
Deprecations? no
Related tickets fixes #331
License Apache 2.0

What's in this PR?

Adds the ability to set the network protocol for external services. Defaults to TCP and behaves almost identically to the recent addition to support this for internal listeners in #320.

It also adds the ability to set the loadBalancerClass for external services. This is useful when using cloud based load balancers.

Example:

  externalServices:
    - name: "clusterip"
      spec:
        type: ClusterIP
        portConfigs:
          - port: 8080
            internalListenerName: "http"
          - port: 7182
            internalListenerName: "my-custom-listener"
            protocol: TCP
      metadata:
        annotations:
          toto: tata
        labels:
          titi: tutu

And to set a loadBalancerClass:

externalServices:
    - name: "nlb"
      spec:
        type: LoadBalancer
        loadBalancerClass: "service.k8s.aws/nlb"
        portConfigs:
          - port: 8080
            internalListenerName: "http"
          - port: 7182
            internalListenerName: "my-custom-listener"
            protocol: TCP
      metadata:
        annotations:
          toto: tata
        labels:
          titi: tutu

Why?

It's possible to set the network protocol for container ports but not for services, so this just completes the feature.

Checklist

  • Implementation tested
  • Error handling code meets the guideline
  • Logging code meets the guideline
  • User guide and development docs updated (if needed)
  • Append changelog with changes

@mh013370 mh013370 changed the title Add ability to configure network protocol for external service configs Add ability to configure network protocol and load balancer class for external service configs Dec 13, 2023
Copy link
Contributor

@juldrixx juldrixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add in the example loadBalancerClass as you did for protocol?

@mh013370
Copy link
Member Author

Can you add in the example loadBalancerClass as you did for protocol?

In the docs? Surely!

@juldrixx juldrixx merged commit 26f606a into konpyutaika:master Dec 14, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to set port network protocol (TCP/UDP) and LoadBalancerClass in externalServices
2 participants