-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to configure network protocol and load balancer class for external service configs #335
Merged
juldrixx
merged 10 commits into
konpyutaika:master
from
mh013370:add-protocol-external-services
Dec 14, 2023
Merged
Add ability to configure network protocol and load balancer class for external service configs #335
juldrixx
merged 10 commits into
konpyutaika:master
from
mh013370:add-protocol-external-services
Dec 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mh013370
changed the title
Add ability to configure network protocol for external service configs
Add ability to configure network protocol and load balancer class for external service configs
Dec 13, 2023
juldrixx
requested changes
Dec 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add in the example loadBalancerClass
as you did for protocol
?
In the docs? Surely! |
juldrixx
requested changes
Dec 14, 2023
site/docs/5_references/1_nifi_cluster/7_external_service_config.md
Outdated
Show resolved
Hide resolved
juldrixx
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Adds the ability to set the network protocol for external services. Defaults to
TCP
and behaves almost identically to the recent addition to support this for internal listeners in #320.It also adds the ability to set the
loadBalancerClass
for external services. This is useful when using cloud based load balancers.Example:
And to set a
loadBalancerClass
:Why?
It's possible to set the network protocol for container ports but not for services, so this just completes the feature.
Checklist