Add cross-platform docker builds #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mh013370
changed the title
Closed
|
@juldrixx Please hold on merging this. I've just noticed that we are no longer generating manifests prior to building the image with this change. |
mh013370
commented
Mar 14, 2023
|
Okay this is good to go. I re-verified that cross-platform images are built :) |
juldrixx
approved these changes
Mar 14, 2023
juldrixx
added a commit
that referenced
this pull request
Mar 14, 2023
|
The build failed after the merged see |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
PR #205 made cross-platform docker image builds possible. This PR makes the nifikop docker image published cross-platform following the below docs:
Why?
To enable running nifikop on multiple architectures.
Checklist