Adding nifi.sensitive.props.key to all config samples #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. This makes simplecluster deployable out of the box. Previously, the nifi pods would get endlessly restarted since this property wasn't getting set. |
mh013370
approved these changes
Jul 20, 2022
erdrix
approved these changes
Jul 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
From apache/nifi:1.14.0, the
nifi.sensitive.props.keyinnifi.propertiesis mandatory.To fix the sample YAMLs in
config/samples/I've added an override so they can used out of the boxAdditional context
This was an optional field in <1.13.0, so is not a breaking change if users try to deploy a lower version
Checklist