docs: tell user if they use rhsa with no cves sooner #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
|
/retest |
johnbieren
force-pushed
the
sevlogging
branch
from
5b3a0aa to
ab28cde
Compare
happybhati
approved these changes
Feb 27, 2025
We already tell the user they can't use an RHSA with no cves in the create-advisory task. However, the new set-severity-task runs before the create-advisory task and will also fail if the user specifies RHSA with no cves (it will say it couldn't find a severity for any cve). This commit adds the same error message from create-advisory to set-advisory-severity so it is more clear to the user. Signed-off-by: Johnny Bieren <[email protected]>
johnbieren
force-pushed
the
sevlogging
branch
from
ab28cde to
7c9c944
Compare
|
New changes are detected. LGTM label has been removed. |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already tell the user they can't use an RHSA with no cves in the create-advisory task. However, the new set-severity-task runs before the create-advisory task and will also fail if the user specifies RHSA with no cves (it will say it couldn't find a severity for any cve). This commit adds the same error message from create-advisory to set-advisory-severity so it is more clear to the user.
Describe your changes
Relevant Jira
Checklist before requesting a review
do not mergelabel if there's a dependency PRrelease-service-maintainershandle if you are unsure who to tagSigned-off-by: My name <email>