Skip to content

feat: Added csdiff and git packages#292

Merged
dirgim merged 1 commit into
konflux-ci:mainfrom
jperezdealgaba:csdiff
Sep 9, 2024
Merged

feat: Added csdiff and git packages#292
dirgim merged 1 commit into
konflux-ci:mainfrom
jperezdealgaba:csdiff

Conversation

@jperezdealgaba
Copy link
Copy Markdown
Contributor

@jperezdealgaba jperezdealgaba commented Aug 30, 2024

csdiff and git packages are installed in order to be used by SAST tasks to parse the results and generate fingerprinting.

This will be used by future SAST tasks provided by the OpenScanHub team, for example: https://issues.redhat.com/browse/OSH-737

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@14f1432). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff            @@
##             main      #292   +/-   ##
========================================
  Coverage        ?   100.00%           
========================================
  Files           ?        18           
  Lines           ?       498           
  Branches        ?         0           
========================================
  Hits            ?       498           
  Misses          ?         0           
  Partials        ?         0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jperezdealgaba jperezdealgaba force-pushed the csdiff branch 3 times, most recently from 123a053 to f67dbe6 Compare September 2, 2024 14:02
@jperezdealgaba
Copy link
Copy Markdown
Contributor Author

@ralphbean Would you mind giving a review on this?

Copy link
Copy Markdown
Collaborator

@jsztuka jsztuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jperezdealgaba jperezdealgaba marked this pull request as ready for review September 5, 2024 11:52
@jperezdealgaba
Copy link
Copy Markdown
Contributor Author

@ralphbean @14rcole @Josh-Everett Could any of you review it and approve it/comment it? Thank you!

@ralphbean
Copy link
Copy Markdown
Member

/ok-to-test

@jperezdealgaba
Copy link
Copy Markdown
Contributor Author

@ralphbean Would you mind enabling the last CI test? I am not able to trigger it/merge this

@dirgim
Copy link
Copy Markdown
Member

dirgim commented Sep 9, 2024

@jperezdealgaba if you rebase your commit on the latest main, the Red Hat Konflux job issue should get resolved.

@jperezdealgaba jperezdealgaba force-pushed the csdiff branch 2 times, most recently from 3c4a2d3 to fd8d6b2 Compare September 9, 2024 13:54
csdiff and git packages are installed in order to be used by SAST tasks

Package will be used for parsing results and generating fingerprints
and results files

Signed-off-by: Juan Pérez de Algaba <jperezde@redhat.com>
@jperezdealgaba jperezdealgaba changed the title feat: Added csdiff package feat: Added csdiff and git packages Sep 9, 2024
@jperezdealgaba
Copy link
Copy Markdown
Contributor Author

@dirgim I rebased the PR and GitHub is still showing that I need the approval from one maintainer for the workflow:

Screenshot 2024-09-09 at 15 58 16

P.S.: I added the installation of the git packages to this PR as it will be also needed. I hope it is not a problem

@jperezdealgaba
Copy link
Copy Markdown
Contributor Author

All checks passed! I have no merge rights in this repo

Copy link
Copy Markdown
Member

@dirgim dirgim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@dirgim dirgim merged commit 169270b into konflux-ci:main Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants