fix: typo in restoreRelease#1437
Conversation
|
/retest |
1 similar comment
|
/retest |
theflockers
left a comment
There was a problem hiding this comment.
the code look ok, but I am afraid your PR would mess up a bit with the commit tree. Not sure exactly how to fix it . Any idea @johnbieren @happybhati
I'm not really sure what you are saying about the commit tree. This should just be rebased and squashed down to one commit, is that what you mean? I also don't get what this PR is doing. @jinqi7 it would be really nice to include the why of changes you are making in the commit messages |
I was unsure if only squashing would fix it. thansk @johnbieren |
Signed-off-by: Jing Qi <jinqi@redhat.com>
77e8169 to
bc841f8
Compare
It's my bad. I rebased my PR and I only want to submit one commit. |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnbieren, psturc The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
The name of the release file was added a wrong prefix. It's to change it to the correct one.
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Issue ticket number and link
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: