Skip to content

fix: typo in restoreRelease#1437

Merged
openshift-merge-bot[bot] merged 1 commit into
konflux-ci:mainfrom
jinqi7:fix_RELEASE1201
Oct 24, 2024
Merged

fix: typo in restoreRelease#1437
openshift-merge-bot[bot] merged 1 commit into
konflux-ci:mainfrom
jinqi7:fix_RELEASE1201

Conversation

@jinqi7

@jinqi7 jinqi7 commented Oct 23, 2024

Copy link
Copy Markdown
Contributor

The name of the release file was added a wrong prefix. It's to change it to the correct one.

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Issue ticket number and link

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
  • I have updated labels (if needed)

@jinqi7

jinqi7 commented Oct 23, 2024

Copy link
Copy Markdown
Contributor Author

/retest

1 similar comment
@jinqi7

jinqi7 commented Oct 23, 2024

Copy link
Copy Markdown
Contributor Author

/retest

@theflockers theflockers left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the code look ok, but I am afraid your PR would mess up a bit with the commit tree. Not sure exactly how to fix it . Any idea @johnbieren @happybhati

@johnbieren

Copy link
Copy Markdown
Contributor

the code look ok, but I am afraid your PR would mess up a bit with the commit tree. Not sure exactly how to fix it . Any idea @johnbieren @happybhati

I'm not really sure what you are saying about the commit tree. This should just be rebased and squashed down to one commit, is that what you mean? I also don't get what this PR is doing. @jinqi7 it would be really nice to include the why of changes you are making in the commit messages

@theflockers

Copy link
Copy Markdown
Contributor

the code look ok, but I am afraid your PR would mess up a bit with the commit tree. Not sure exactly how to fix it . Any idea @johnbieren @happybhati

I'm not really sure what you are saying about the commit tree. This should just be rebased and squashed down to one commit, is that what you mean? I also don't get what this PR is doing. @jinqi7 it would be really nice to include the why of changes you are making in the commit messages

I was unsure if only squashing would fix it. thansk @johnbieren

Signed-off-by: Jing Qi <jinqi@redhat.com>
@jinqi7

jinqi7 commented Oct 23, 2024

Copy link
Copy Markdown
Contributor Author

the code look ok, but I am afraid your PR would mess up a bit with the commit tree. Not sure exactly how to fix it . Any idea @johnbieren @happybhati

I'm not really sure what you are saying about the commit tree. This should just be rebased and squashed down to one commit, is that what you mean? I also don't get what this PR is doing. @jinqi7 it would be really nice to include the why of changes you are making in the commit messages

I was unsure if only squashing would fix it. thansk @johnbieren

It's my bad. I rebased my PR and I only want to submit one commit.

@psturc psturc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jinqi7

jinqi7 commented Oct 23, 2024

Copy link
Copy Markdown
Contributor Author

/retest

@johnbieren johnbieren left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci

openshift-ci Bot commented Oct 23, 2024

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnbieren, psturc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jinqi7

jinqi7 commented Oct 24, 2024

Copy link
Copy Markdown
Contributor Author

/retest

2 similar comments
@jinqi7

jinqi7 commented Oct 24, 2024

Copy link
Copy Markdown
Contributor Author

/retest

@jinqi7

jinqi7 commented Oct 24, 2024

Copy link
Copy Markdown
Contributor Author

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants