Skip to content

fix: update release multiarch data fields#1433

Merged
openshift-merge-bot[bot] merged 1 commit into
konflux-ci:mainfrom
johnbieren:datafix
Oct 21, 2024
Merged

fix: update release multiarch data fields#1433
openshift-merge-bot[bot] merged 1 commit into
konflux-ci:mainfrom
johnbieren:datafix

Conversation

@johnbieren

Copy link
Copy Markdown
Contributor

This commit fixes two data fields in the multiarch advisories release pipeline test. The product_id field is changed from a string to an int, and the component source is removed from the data section of the ReleasePlanAdmission. The same component source information already appears to be present in the create snapshot function.

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Issue ticket number and link

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
  • I have updated labels (if needed)

@seanconroy2021 seanconroy2021 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@seanconroy2021

Copy link
Copy Markdown
Member

We also need to update the product_id here will open a pr for it:

This commit fixes two data fields in the multiarch advisories release
pipeline test. The product_id field is changed from a string to an int,
and the component source is removed from the data section of the
ReleasePlanAdmission. The same component source information already
appears to be present in the create snapshot function.

Signed-off-by: Johnny Bieren <jbieren@redhat.com>
@johnbieren

Copy link
Copy Markdown
Contributor Author

We also need to update the product_id here will open a pr for it:

done

@seanconroy2021

seanconroy2021 commented Oct 21, 2024

Copy link
Copy Markdown
Member

/approve
/lgtm

@happybhati happybhati left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci

openshift-ci Bot commented Oct 21, 2024

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: happybhati, seanconroy2021

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants