Skip to content

feat: update createReleasePlan function#1431

Merged
openshift-merge-bot[bot] merged 1 commit into
konflux-ci:mainfrom
jinqi7:update_createReleasePlan
Oct 18, 2024
Merged

feat: update createReleasePlan function#1431
openshift-merge-bot[bot] merged 1 commit into
konflux-ci:mainfrom
jinqi7:update_createReleasePlan

Conversation

@jinqi7

@jinqi7 jinqi7 commented Oct 16, 2024

Copy link
Copy Markdown
Contributor

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Issue ticket number and link

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
  • I have updated labels (if needed)

@openshift-ci openshift-ci Bot requested review from Dannyb48 and chipspeak October 16, 2024 09:49
@jinqi7 jinqi7 force-pushed the update_createReleasePlan branch 2 times, most recently from 10addd2 to 29827e7 Compare October 16, 2024 10:10
@jinqi7 jinqi7 changed the title Update create release plan feat: uppdate createReleasePlan function Oct 16, 2024
@jinqi7 jinqi7 changed the title feat: uppdate createReleasePlan function feat: update createReleasePlan function Oct 16, 2024
@jinqi7 jinqi7 force-pushed the update_createReleasePlan branch from 29827e7 to 95de1b4 Compare October 16, 2024 10:14
@jinqi7 jinqi7 requested a review from a team October 16, 2024 10:24
johnbieren
johnbieren approved these changes Oct 16, 2024
View reviewed changes

@johnbieren johnbieren left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm
very nice having just one function to create the RP

@openshift-ci openshift-ci Bot added the lgtm label Oct 16, 2024
@jinqi7

jinqi7 commented Oct 16, 2024

Copy link
Copy Markdown
Contributor Author

/approve

@jinqi7 jinqi7 force-pushed the update_createReleasePlan branch from 95de1b4 to 1934579 Compare October 16, 2024 11:38
@openshift-ci openshift-ci Bot removed the lgtm label Oct 16, 2024
@johnbieren

johnbieren commented Oct 16, 2024

Copy link
Copy Markdown
Contributor

What is all this storeRelease stuff that was just added? Why is it part of the same PR?

@jinqi7 jinqi7 force-pushed the update_createReleasePlan branch from 1934579 to 22664af Compare October 16, 2024 12:17
johnbieren
johnbieren approved these changes Oct 16, 2024
View reviewed changes

@johnbieren johnbieren left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm label Oct 16, 2024
@openshift-ci

openshift-ci Bot commented Oct 16, 2024

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jinqi7, johnbieren, mmalina

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jinqi7

jinqi7 commented Oct 16, 2024

Copy link
Copy Markdown
Contributor Author

What is all this storeRelease stuff that was just added? Why is it part of the same PR?

It's something from another PR. Removed them. Thx

@jinqi7

jinqi7 commented Oct 16, 2024

Copy link
Copy Markdown
Contributor Author

/retest

@jinqi7

jinqi7 commented Oct 16, 2024

Copy link
Copy Markdown
Contributor Author

/retest

2 similar comments
@jinqi7

jinqi7 commented Oct 17, 2024

Copy link
Copy Markdown
Contributor Author

/retest

@jinqi7

jinqi7 commented Oct 17, 2024

Copy link
Copy Markdown
Contributor Author

/retest

@jinqi7
feat: update createReleasePlan function
2d863cd 
Signed-off-by: Jing Qi <jinqi@redhat.com>
@jinqi7 jinqi7 force-pushed the update_createReleasePlan branch from 22664af to 2d863cd Compare October 17, 2024 04:08
@openshift-ci openshift-ci Bot removed the lgtm label Oct 17, 2024
@jinqi7

jinqi7 commented Oct 17, 2024

Copy link
Copy Markdown
Contributor Author

/retest

3 similar comments
@jinqi7

jinqi7 commented Oct 17, 2024

Copy link
Copy Markdown
Contributor Author

/retest

@jinqi7

jinqi7 commented Oct 17, 2024

Copy link
Copy Markdown
Contributor Author

/retest

@jinqi7

jinqi7 commented Oct 17, 2024

Copy link
Copy Markdown
Contributor Author

/retest

@flacatus

flacatus commented Oct 18, 2024

Copy link
Copy Markdown
Member

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Oct 18, 2024
@openshift-merge-bot openshift-merge-bot Bot merged commit c69d596 into konflux-ci:main Oct 18, 2024
This was referenced Oct 18, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mmalina mmalina mmalina approved these changes

@johnbieren johnbieren johnbieren approved these changes

@chipspeak chipspeak Awaiting requested review from chipspeak

@Dannyb48 Dannyb48 Awaiting requested review from Dannyb48

Assignees

@johnbieren johnbieren

@flacatus flacatus

Labels

1-5 min approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jinqi7 @johnbieren @flacatus @mmalina