fix(rhtapbugs=975): use source_url instead of repo_url for git-url#235
Merged
Conversation
The repo_url variable in pull request jobs points to the target repo. The git-url parameter of build pipelineRuns is passed to the integration service. If users attempt to clone this URL with the revision from the 'revision' parameter (which is the revision of the source URL) an error will occur. Tekton also has a 'source_url' variable that points to the source repo in pull request jobs, which fixes the problem. In push jobs 'source_repo' defaults to the same value as 'repo_url'. Therefore defaulting to 'source_repo' should not cause any other bugs' Signed-off-by: Ryan Cole <rcyoalne@gmail.com>
14rcole
force-pushed
the
rhtapbugs-975
branch
from
2bd59ca to
cfa7d0b
Compare
|
Contributor
|
/test build-service-e2e |
|
/test build-service-e2e |
Contributor
Author
|
/retest-required |
Contributor
Author
|
@mmorhun Can you please merge this? I don't have write access. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The repo_url variable in pull request jobs points to the target repo. The git-url parameter of build pipelineRuns is passed to the integration service. If users attempt to clone this URL with the revision from the 'revision' parameter (which is the revision of the source URL) an error will occur. Tekton also has a 'source_url' variable that points to the source repo in pull request jobs, which fixes the problem. In push jobs 'source_repo' defaults to the same value as 'repo_url'. Therefore defaulting to 'source_repo' should not cause any other bugs'
Checklist:
make testpasses