Skip to content

Add grafana dashboards for initial build/provision upon component cre…#227

Merged
rcerven merged 2 commits into
konflux-ci:mainfrom
rcerven:slo_dashboards
Dec 22, 2023
Merged

Add grafana dashboards for initial build/provision upon component cre…#227
rcerven merged 2 commits into
konflux-ci:mainfrom
rcerven:slo_dashboards

Conversation

@rcerven
Copy link
Copy Markdown
Contributor

@rcerven rcerven commented Dec 11, 2023

…ation, simple builds, PaC provisions and unprovisions and triggers

STONEBLD-1773
STONEBLD-1774

@openshift-ci openshift-ci Bot requested review from mmorhun and psturc December 11, 2023 20:22
@rcerven rcerven force-pushed the slo_dashboards branch 2 times, most recently from bef455e to 24b671d Compare December 11, 2023 20:29
Signed-off-by: Robert Cerven <rcerven@redhat.com>
…ation, simple builds, PaC provisions and unprovisions and triggers

STONEBLD-1773
STONEBLD-1774

Signed-off-by: Robert Cerven <rcerven@redhat.com>
@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.4% Duplication on New Code

See analysis details on SonarCloud

@rcerven
Copy link
Copy Markdown
Contributor Author

rcerven commented Dec 12, 2023

/retest

@chmeliik
Copy link
Copy Markdown
Contributor

How should we review this? Which parts of the generated config are relevant? Or how could we deploy it and view it ourselves?

@rcerven
Copy link
Copy Markdown
Contributor Author

rcerven commented Dec 13, 2023

How should we review this? Which parts of the generated config are relevant? Or how could we deploy it and view it ourselves?

in diff you can see that it shows 1 file as moved and changed (so there you can see actual changes I've made basically for all of them), so I've used "template" from existing dashboards and changed just metric name & those descriptions

@chmeliik
Copy link
Copy Markdown
Contributor

How should we review this? Which parts of the generated config are relevant? Or how could we deploy it and view it ourselves?

in diff you can see that it shows 1 file as moved and changed (so there you can see actual changes I've made basically for all of them), so I've used "template" from existing dashboards and changed just metric name & those descriptions

That helps 👍 So all the dashboards are pretty much copy-pastes of each other, just for different metrics?

Still though, if I wanted to deploy it and check it on my cluster, how would I do it? I probably know how to deploy it at least (https://redhat-appstudio.github.io/infra-deployments/docs/development/deployment.html#deploying-your-versions-of-crds) but not sure where to see the dashboard

@rcerven
Copy link
Copy Markdown
Contributor Author

rcerven commented Dec 13, 2023

in the cluster find namespace : appstudio-grafana

there check route, and there is url to grafana and there you can see dashboards

{
"editorMode": "builder",
"exemplar": false,
"expr": "redhat_appstudio_buildservice_simple_build_pipeline_creation_time_count",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So for this example, metric simple_build_pipeline_creation_time is exported from build-service controller, and does redhat_appstudio_buildservice_simple_build_pipeline_creation_time_count map to that metric?

Does its format follow some Grafana or Promethues expression spec?

Is part redhat_appstudio_buildservice_ fixed and defined for build-service specifically?

Does part _count show the calculation on the collected data of the metric?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Does its format follow some Grafana or Promethues expression spec?"
not sure what you mean, I don't know much about grafana of prometheus

but in the cluster our metric : simple_build_pipeline_creation_time
has to be queried as : redhat_appstudio_buildservice_simple_build_pipeline_creation_time

_count calculates number of metrics
_sum does sum for them
those are prometheus/grafana thingies

@tkdchen
Copy link
Copy Markdown
Contributor

tkdchen commented Dec 14, 2023

/test build-service-e2e

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 14, 2023

@rcerven: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/build-service-e2e 7ddcaa4 link true /test build-service-e2e

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tkdchen
Copy link
Copy Markdown
Contributor

tkdchen commented Dec 14, 2023

Deployed on my cluster. The dashboards are shown, however after submitting a few builds, both simple and PaC builds, number is still 0 in the dashboard by waiting for a while after the submission. "No data" is shown inside initial build dashboard. Any additional configuration should be done after bootstrapping the cluster?

@rcerven
Copy link
Copy Markdown
Contributor Author

rcerven commented Dec 14, 2023

Deployed on my cluster. The dashboards are shown, however after submitting a few builds, both simple and PaC builds, number is still 0 in the dashboard by waiting for a while after the submission. "No data" is shown inside initial build dashboard. Any additional configuration should be done after bootstrapping the cluster?

I have no idea

I was testing those metrics which we are sending to prometheus in dev cluster and those extended names worked

not sure what has to be done for dashboards

Copy link
Copy Markdown
Member

@mmorhun mmorhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants