Remove unused parameters and result#737
Closed
mkosiarc wants to merge 0 commit into
Closed
Conversation
Contributor
Author
|
/retest |
mkosiarc
force-pushed
the
remove-skip-optional
branch
2 times, most recently
from
53a53d7 to
5063b46
Compare
Contributor
Author
|
/retest |
mkosiarc
force-pushed
the
remove-skip-optional
branch
from
5063b46 to
183f396
Compare
Contributor
Author
|
/retest |
1 similar comment
Contributor
Author
|
/retest |
chmeliik
reviewed
Jan 12, 2024
tkdchen
reviewed
Jan 15, 2024
mkosiarc
force-pushed
the
remove-skip-optional
branch
from
183f396 to
7ed5bff
Compare
mkosiarc
changed the title
mkosiarc
force-pushed
the
remove-skip-optional
branch
from
7ed5bff to
6e59b81
Compare
chmeliik
approved these changes
Jan 15, 2024
Contributor
chmeliik
left a comment
chmeliik
left a comment
There was a problem hiding this comment.
LGTM, tiny nitpick in the migration doc
mkosiarc
force-pushed
the
remove-skip-optional
branch
from
6e59b81 to
ac6912f
Compare
Contributor
Author
|
/retest |
4 similar comments
Contributor
Author
|
/retest |
Contributor
Author
|
/retest |
Contributor
Author
|
/retest |
Contributor
Author
|
/retest |
mmorhun
approved these changes
Jan 16, 2024
mkosiarc
force-pushed
the
remove-skip-optional
branch
from
ac6912f to
33e86b9
Compare
|
Contributor
Author
|
Accidentally closed this PR by pushing main branch, could not reopen - opened a new identical PR #746 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parameters skip-optional, pipelinerun-name and pipelinerun-uid are
no longer used in init task and neither is the container-registry-secret
result.
New version for init task was created together with the migration doc
and the reference was updated in the pipeline
STONEBLD-2000