attempt to fix yamllint

[stuartwdouglas]

My theory is that pipelines 1.13 broke workingDir somehow.

[stuartwdouglas]

/retest

[tkdchen]

LGTM

[tkdchen]

/test build-definitions-pull-request

[mkosiarc]

/retest

[mkosiarc]

/retest

[zregvart]

Looking at the logs, seems that there are two linting issues that are reported as a warning:

./source/.github/workflows/check-buildah-remote.yaml
  2:1       warning  truthy value should be one of [false, true]  (truthy)

./source/task/update-infra-deployments/0.1/update-infra-deployments.yaml
  28:6      warning  comment not indented like content  (comments-indentation)

That tells me that the configuration from .yamlint is considered.

I see e2e tests failure though, obviously not related to this change:

[build-service-suite Build templates E2E test] HACBS pipelines should eventually finish successfully for component with Git source URL https://github.com/redhat-appstudio-qe/devfile-sample-python-basic [build, build-templates, HACBS, pipeline, build-templates-e2e]
/github.com/redhat-appstudio/e2e-tests/tests/build/build_templates.go:148
  PipelineRun devfile-sample-python-basic-exzo-g9ccm reason: Failed
  failed to store PipelineRun build-templates-e2e:devfile-sample-python-basic-exzo-g9ccm: mkdir /root/tmp: permission denied
  attempt 1/3: PipelineRun "devfile-sample-python-basic-exzo-g9ccm" failed: PipelineRun devfile-sample-python-basic-exzo-g9ccm reason: Failed
  failed to store PipelineRun build-templates-e2e:devfile-sample-python-basic-exzo-g9ccm: mkdir /root/tmp: permission denied
  attempt 2/3: PipelineRun "devfile-sample-python-basic-exzo-g9ccm" failed: PipelineRun devfile-sample-python-basic-exzo-g9ccm reason: Failed
  failed to store PipelineRun build-templates-e2e:devfile-sample-python-basic-exzo-g9ccm: mkdir /root/tmp: permission denied
  attempt 3/3: PipelineRun "devfile-sample-python-basic-exzo-g9ccm" failed:   [FAILED] in [It] - /github.com/redhat-appstudio/e2e-tests/tests/build/build_templates.go:152 @ 12/21/23 03:56:25.543
• [FAILED] [0.412 seconds]
[build-service-suite Build templates E2E test] HACBS pipelines [It] should eventually finish successfully for component with Git source URL https://github.com/redhat-appstudio-qe/devfile-sample-python-basic [build, build-templates, HACBS, pipeline, build-templates-e2e]
/github.com/redhat-appstudio/e2e-tests/tests/build/build_templates.go:148

  [FAILED] Expected success, but got an error:
      <*errors.errorString | 0xc001904e20>: 
      
      {s: ""}
  In [It] at: /github.com/redhat-appstudio/e2e-tests/tests/build/build_templates.go:152 @ 12/21/23 03:56:25.543

[stuartwdouglas]

./source/task/update-infra-deployments/0.1/update-infra-deployments.yaml can be fixed, the ./source/.github/workflows/check-buildah-remote.yaml one is a problem with the linter. Github actions uses on: as a key, it thinks on is a truthy value and should be replaced with true. Either way these are both warnings and have been on existing PRs for a long time.

[sonarqubecloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud