Improve the performance and validation of validate-fbc task#1953
Merged
Conversation
The computation of differential related images has been improved by removing jq operations which require large arrays to be loaded. related: konflux-ci/konflux-test#364 Signed-off-by: arewm <arewm@users.noreply.github.com>
arewm
changed the title
arewm
force-pushed
the
reduce-validate-fbc-resources
branch
from
a9f6648 to
13f40af
Compare
arewm
force-pushed
the
reduce-validate-fbc-resources
branch
from
13f40af to
ca3a275
Compare
yashvardhannanavati
left a comment
yashvardhannanavati
left a comment
Contributor
There was a problem hiding this comment.
One minor comment. lgtm code wise!
arewm
force-pushed
the
reduce-validate-fbc-resources
branch
4 times, most recently
from
37d974f to
a6e779e
Compare
Member
Author
|
@konflux-ci/integration-service-maintainers @konflux-ci/operator-foundry , CI has now passed on this task update. Would you be able to review? We can work to further reduce the memory requirements in the future. Do you want me to try to reduce the memory requirements as they are? I suspect that some FBC components might need more memory than others due to the size of their generated fragments and the number of related images (this will therefore also increase as the age of a catalog increases as the number of package versions and therefore the number of related images will increase). |
yashvardhannanavati
requested changes
Feb 20, 2025
arewm
force-pushed
the
reduce-validate-fbc-resources
branch
from
a6e779e to
a16e461
Compare
* Check to make sure that a valid base image tag is found * Properly catch failure to retrieve differential base iamges resolves: KONFLUX-6943 Signed-off-by: arewm <arewm@users.noreply.github.com>
arewm
force-pushed
the
reduce-validate-fbc-resources
branch
from
a16e461 to
bbef1d4
Compare
yashvardhannanavati
approved these changes
Feb 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce the resources required for the validate-fbc task
The computation of differential related images has been improved by removing jq operations which require large arrays to be loaded.
related: konflux-ci/konflux-test#364
Improve validation handling for FBC
resolves: KONFLUX-6943