Link to migration bundles#1861
Merged
Merged
Conversation
tkdchen
force-pushed
the
link-migration-bundles
branch
from
667dc90 to
110af20
Compare
tkdchen
force-pushed
the
link-migration-bundles
branch
2 times, most recently
from
a72139f to
bc49d05
Compare
tkdchen
force-pushed
the
link-migration-bundles
branch
from
1f6fbd8 to
70eeb3f
Compare
Contributor
Author
|
Rebased on main branch for fixing code conflict. |
Contributor
Author
|
/retest build-definitions-pull-request |
Contributor
Author
|
/test build-definitions-pull-request |
1 similar comment
Contributor
Author
|
/test build-definitions-pull-request |
chmeliik
reviewed
Feb 12, 2025
chmeliik
reviewed
Feb 12, 2025
mmorhun
reviewed
Feb 12, 2025
tkdchen
force-pushed
the
link-migration-bundles
branch
2 times, most recently
from
00e2708 to
c38b633
Compare
Contributor
Author
|
Added a new commit to address review comment and rebased to fix code conflict between the new commit and the one merged into the main branch. |
chmeliik
previously approved these changes
Feb 14, 2025
mmorhun
reviewed
Feb 14, 2025
tkdchen
force-pushed
the
link-migration-bundles
branch
from
9715930 to
6e59333
Compare
Contributor
Author
chmeliik
reviewed
Feb 17, 2025
Comment on lines
+444
to
+447
| local limit=1 | ||
| if [ -n "$TEST_REPO_NAME" ]; then | ||
| limit=10 | ||
| fi |
Contributor
There was a problem hiding this comment.
Now that we're using the filter_tag_name param, do we still need to list more than 1 digest? If yes, could you add a comment with the reason why?
Contributor
Author
There was a problem hiding this comment.
Now, only list 1 tag.
mmorhun
reviewed
Feb 17, 2025
tkdchen
force-pushed
the
link-migration-bundles
branch
from
6e59333 to
61ebe5d
Compare
STONEBLD-3214
Any task bundles that have migrations are linked by the newer task
bundles by a dedicated annotation. See the following example task
bundles:
+-------+------+ +------+-------+
v | | v | |
tb0 --> tb1 --> tb2 --> tb3 --> tb4 --> tb5
| |
M M
where, tb2 and tb3 point to tb1, and tb4 and tb5 point to tb3.
Linking task bundles helps to reduce the number of HTTP requests made to
Quay.io that query which task bundles have migrations.
Terms:
- tb means task bundle.
- M means migration.
tkdchen
force-pushed
the
link-migration-bundles
branch
from
61ebe5d to
c7e493a
Compare
mmorhun
reviewed
Feb 18, 2025
| output=$(build_push_task "$task_dir" "$prepared_task_file" "$task_bundle" "$task_file_sha" "$has_migration") | ||
| output=$( | ||
| build_push_task "$task_dir" "$prepared_task_file" "$task_bundle" "$task_file_sha" \ | ||
| "$has_migration" "$previous_migration_bundle_digest" |
Member
There was a problem hiding this comment.
Is previous_migration_bundle_digest used anywhere?
Contributor
Author
There was a problem hiding this comment.
mmorhun
approved these changes
Feb 18, 2025
mmorhun
left a comment
mmorhun
left a comment
Member
There was a problem hiding this comment.
Approving with agreement to update the annotation name in a follow up PR.
Also, please take a look at the question above.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
STONEBLD-3214
Any task bundles that have migrations are linked by the newer task bundles by a dedicated annotation. See the following example task bundles:
where, tb2 and tb3 point to tb1, and tb4 and tb5 point to tb3.
Linking task bundles helps to reduce the number of HTTP requests made to Quay.io that query which task bundles have migrations.
Terms: