Make EC strict mode configurable#1630
Conversation
5f0f7d4 to
0b27a85
Compare
|
This marks the The latter will need changes in the integration-service I guess |
zregvart
left a comment
There was a problem hiding this comment.
LGTM. cc @konflux-ci/ec
|
/ok-ot-test |
|
I see the value of doing this, just please be wary that if the check is green no one usually digs through the check to see if there are any issues. If setting strict to false, there is a high chance that you won't find out about issues until release time which is usually not a great user experience. Could you update the description of the parameter to provide some sort of warning to future users thinking about setting struct to false? |
|
/ok-to-test (without typos now 😅) |
0b27a85 to
47cf4d5
Compare
Sure |
47cf4d5 to
34e29f8
Compare
Signed-off-by: Julen Landa Alustiza <jlanda@redhat.com>
34e29f8 to
93d4775
Compare
|
/ok-to-test |
Allow modifying
STRICT. This allows to mark an EC as informative and not gate changes on it.This is useful for us while we iterate to fix all the violations without gating yet the pull requests