Revert "[ISV-5221] Add new step to inject and push SBOMs in build-ima…#1565
Closed
rcerven wants to merge 4 commits into
Closed
Revert "[ISV-5221] Add new step to inject and push SBOMs in build-ima…#1565rcerven wants to merge 4 commits into
rcerven wants to merge 4 commits into
Conversation
…ge-index task." This reverts commit 05cb676.
arewm
approved these changes
Nov 1, 2024
Member
arewm
left a comment
arewm
left a comment
There was a problem hiding this comment.
These changes are causing the Tekton results to overflow since new steps results in a smaller space for results in each task step.
Member
|
/retest |
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
chmeliik
requested changes
Nov 4, 2024
Contributor
chmeliik
left a comment
chmeliik
left a comment
There was a problem hiding this comment.
I would like stronger proof that the problem was the result limit. Have you tested with the affected user that this resolves the issue?
Contributor
Probably no need to bother. The affected user was using an older version of the task, this change wasn't even included. We can probably close this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ge-index task."
This reverts commit 05cb676.
Before you complete this pull request ...
Look for any open pull requests in the repository with the title "e2e-tests update" and
see if there are recent e2e-tests updates that will be applicable to your change.
reverting it because it is causing problems with results limit, since it added more steps