subscription-manager pre-registration#1528
Merged
Merged
Conversation
Member
Author
|
/retest |
|
Tested with the buildah task, works well 🎉 |
Member
Author
|
/retest |
brianwcook
added a commit
to konflux-ci/buildah-container
that referenced
this pull request
Oct 23, 2024
install subscription manager in the buildah-task container to support konflux-ci/build-definitions#1528
Member
Author
|
opened konflux-ci/buildah-container#98 to get subscription-manager included in buildah-task |
brianwcook
force-pushed
the
pre-registration
branch
from
0d25118 to
04fa071
Compare
|
Works on ubi9 as well :) |
brianwcook
force-pushed
the
pre-registration
branch
from
04fa071 to
3f76f33
Compare
Member
Author
|
rebased and removed dnf install. |
chmeliik
reviewed
Oct 24, 2024
| # user is not running registration in the Containerfile: pre-register. | ||
| echo "Pre-registering with subscription manager." | ||
| subscription-manager register --org "$(cat /tmp/activation-key/org)" --activationkey "$(cat /tmp/activation-key/activationkey)" | ||
| REGISTERED=$? |
Contributor
There was a problem hiding this comment.
Suggested change
| REGISTERED=$? | |
| trap 'subscription-manager unregister' EXIT |
This will make us unregister always, even if the build fails
Member
Author
There was a problem hiding this comment.
did not get this in but I will file a follow up PR. testing all cases manually was getting complicated
Member
Author
|
/retest |
brianwcook
force-pushed
the
pre-registration
branch
from
3f76f33 to
7fcb461
Compare
Member
Author
|
i'm doing some add'l testing, don't merge for now. |
brianwcook
force-pushed
the
pre-registration
branch
from
50b501a to
f348569
Compare
This add support for pre-registering with subscription-manager in the buildah tasks (0.2 only). When activation keys are provided the buildah-task container will register and then provide certs to the buildah env via volume mounts so that users do not need to add subscription-manager register commands to the Containerfiles. This makes downstreaming somewhat easier and addresses negative user feedback.
brianwcook
force-pushed
the
pre-registration
branch
from
f348569 to
01d22b4
Compare
Member
Author
|
this is ready to go. tested with:
|
ptoscano
reviewed
Oct 25, 2024
ptoscano
reviewed
Oct 25, 2024
This was referenced Nov 19, 2024
arewm
pushed a commit
to arewm/buildah-container
that referenced
this pull request
Jan 6, 2025
install subscription manager in the buildah-task container to support konflux-ci/build-definitions#1528
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This add support for pre-registering with subscription-manager in the buildah tasks (0.2 only). When activation keys are provided the buildah-task container will register and then provide certs to the buildah env via volume mounts so that users do not need to add subscription-manager register commands to the Containerfiles. This makes downstreaming somewhat easier and addresses negative user feedback.
Before you complete this pull request ...
Look for any open pull requests in the repository with the title "e2e-tests update" and
see if there are recent e2e-tests updates that will be applicable to your change.