CI check for missing TA Task variants#1523
Merged
Merged
Conversation
zregvart
force-pushed
the
issue/EC-934
branch
from
5a7b115 to
c8bc225
Compare
lcarva
approved these changes
Oct 21, 2024
| trap 'rm "${tmp_files[@]}" > /dev/null 2>&1' EXIT | ||
|
|
||
| # names of workspaces that will not be mounted via PVC, as inline array | ||
| non_pvc_workspaces='["ssh-directory", "basic-auth", "gitops-auth", "git-basic-auth", "netrc"]' |
Contributor
There was a problem hiding this comment.
Not sure if it's worth it, but it would be nice if this list was generated from
build-definitions/policies/all-tasks.yaml
Lines 10 to 14 in 7fe56f1
Contributor
Author
There was a problem hiding this comment.
I think this is a good idea, incorporated in 324b27e (#1523)
A script and a GitHub workflow change to check if a new Task was added that uses a PVC-backed workspace without a Trusted Artifacts Task variant. Reference: https://issues.redhat.com/browse/EC-934
zregvart
force-pushed
the
issue/EC-934
branch
from
c8bc225 to
324b27e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A script and a GitHub workflow change to check if a new Task was added that uses a PVC-backed workspace without a Trusted Artifacts Task variant.
Reference: https://issues.redhat.com/browse/EC-934