fix(KFLUXBUGS-1693): remove fail-unsigned param from task#1492
Merged
Conversation
- Update task - Add MIGRATION.md - Update template version Signed-off-by: Avi Biton <abiton@redhat.com>
Member
Author
|
@lcarva Can you please take a look? |
lcarva
approved these changes
Oct 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fail-unsigned parameter was removed from the task.
The task will only fail if the scanner fails, otherwise it will end successfully providing the RPMS_DATA result with the signature keys and the number of unsigned RPMs.
EC will process the result and determine whether it should pass or fail.