Deprecate buildah task resource variations#1475
Merged
Merged
Conversation
mmorhun
requested review from
MartinBasti,
arewm,
brianwcook,
chmeliik,
gbenhaim,
lcarva,
mkosiarc,
psturc,
rcerven,
scoheb,
tkdchen and
tnevrlka
rcerven
approved these changes
Sep 26, 2024
arewm
approved these changes
Sep 26, 2024
chmeliik
reviewed
Sep 26, 2024
Contributor
There was a problem hiding this comment.
With conforma/policy#1156, we can make the expiry message more useful. The default says Upgrade to a newer version of the task, which doesn't apply here. We should suggest to switch to the regular buildah task and link the resource configuration docs
mkosiarc
approved these changes
Sep 27, 2024
mmorhun
force-pushed
the
STONEBLD-2825
branch
from
7b14280 to
4cb5762
Compare
chmeliik
approved these changes
Sep 27, 2024
mmorhun
force-pushed
the
STONEBLD-2825
branch
from
4cb5762 to
eda9358
Compare
Contributor
|
@mmorhun Can we merge this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since it's possible to set task resources from pipeline run in Konflux (docs), we are deprecation
buildah-*gbtasks.