Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Yang/nav bari os15 issue #7

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Yang/nav bari os15 issue #7

wants to merge 3 commits into from
+4 −10

Conversation

yangchen-acc
Copy link
Collaborator

The navigation bar looks weird on iOS, removed some unnecessary code

ColinCammaranoAccolade
ColinCammaranoAccolade reviewed Jan 14, 2022
View reviewed changes
Copy link
Collaborator

@ColinCammaranoAccolade ColinCammaranoAccolade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you paste some screenshots here of what this changes?

@yangchen-acc
Copy link
Collaborator Author

yangchen-acc commented Jan 20, 2022 •
edited
Loading

Could you paste some screenshots here of what this changes?

Simulator Screen Shot - iPhone 13 - 2022-01-19 at 17 27 35
Simulator Screen Shot - iPhone 13 - 2022-01-19 at 17 33 15
@ColinCammaranoAccolade Sorry for the late reply, please see the top part of the navigationbar, the first one is before update, it has a transparent background

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ColinCammaranoAccolade ColinCammaranoAccolade ColinCammaranoAccolade left review comments

@daisyduong-acc daisyduong-acc Awaiting requested review from daisyduong-acc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yangchen-acc @ColinCammaranoAccolade