Feature: Pass in a pre-configured route53 boto3 client to Route53Dns provider #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…provider Covers cases where the caller: - has STS credentials - where a AssumeRole is necessary (E.G. Hosted Zone in a different AWS Account).
Codecov Report
@@ Coverage Diff @@
## master #198 +/- ##
==========================================
+ Coverage 87.44% 87.48% +0.04%
==========================================
Files 18 18
Lines 1131 1135 +4
==========================================
+ Hits 989 993 +4
Misses 142 142
Continue to review full report at Codecov.
|
mmaney
added a commit
that referenced
this pull request
Sep 19, 2020
…provider (#213) Covers cases where the caller: - has STS credentials - where a AssumeRole is necessary (E.G. Hosted Zone in a different AWS Account). Co-authored-by: Turtle Kalus <[email protected]> (reconciled from #198 by @mmaney)
|
Minor adjustment to merge with current HEAD, merged as #213 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What(What have you changed?)
Allowing the caller to pass in a pre-configured route53 boto3 client on the Route53Dns provider
Why(Why did you change it?)
Covers use-cases where the caller:
Closes #197