Remove JndiLookup class from shaded jar #621
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the recommendation by the log4j security team, removing the class is the best way to move forward: https://logging.apache.org/log4j/2.x/security.html
This filters out the class when building the shaded jar.
Before
After
What this doesn't protect against is when someone doesn't use the compiled jar file, for example when doing local development.
Relates to #620
cc @hbruch