evaluate extratags->linked_place from placex table #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In recent versions of Nominatim the type of a linked place has been moved from extratags->place to extratags->linked_place so that it does not overwrite values set by mappers. Change Photon to look at both fields. Keep a preference to the 'place' value as this would be whatever the mapper has chosen. This change is backward compatible in the sense that Photon works with older and newer versions of Nominatim. Fixes komoot#489.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In recent versions of Nominatim the type of a linked place
has been moved from extratags->place to extratags->linked_place
so that it does not overwrite values set by mappers.
Change Photon to look at both fields. Keep a preference to the
'place' value as this would be whatever the mapper has chosen.
This change is backward compatible in the sense that Photon works
with older and newer versions of Nominatim.
Fixes #489.