Fix for the house number cause the erratic behaviour #391

DavidGorritiGeograma · 2019-03-14T09:39:42Z

e.g. we received a golf course hole in Australia instead of an address in Austria as the following:
http://photon.komoot.de/api/?q=3%20Universitaetsplatz,%20graz,%20austria

With location_bias_scale, it still shows the first two results in Italy:
http://photon.komoot.de/api/?q=3%20Universitaetsplatz,%20graz,%20austria&lat=47.58472242&lon=14.13731478&location_bias_scale=10

However, the result is correct without house number:
http://photon.komoot.de/api/?q=Universitaetsplatz,%20graz,%20austria

Therefore, we increase the prefix matching number, and boost the city and street name to increase the rank of the matching location names.
And modify the bias boost mode to locate the result closer to the bias center.

Thanks for your review and help!
David Gorriti

golf course hole in Australia instead of an adress in Austria.

simonpoole · 2019-04-08T07:46:24Z

src/main/java/de/komoot/photon/query/PhotonQueryBuilder.java

@@ -50,29 +50,32 @@
    private MatchQueryBuilder defaultMatchQueryBuilder;

    private MatchQueryBuilder languageMatchQueryBuilder;
+
+    private MatchQueryBuilder numricMatchQueryBuilder;



This variable isn't used anywhere , and should be removed or used (PS it would be "numeric").

Thank you very much! I removed the unused the parameter. By the way, could you please help me to review if there is a better solution to solve the issue? Thanks again!
David

We are rather thin on ES knowledge here and up to now none of the relevant experts has weighed in yet, but, speaking for myself, the main question is how much this impacts the behaviour outside of the specific case you've been looking at (which it clearly improves). In my preliminary tests the change in behaviour is large so it will take some time to get to a definite conclusion on the PR.

Thank you so much for your explanation and help!

simonpoole · 2019-04-08T13:41:20Z

src/main/java/de/komoot/photon/query/PhotonQueryBuilder.java

        // @formatter:off
        m_queryBuilderForTopLevelFilter = QueryBuilders.boolQuery()
                .should(QueryBuilders.boolQuery().mustNot(QueryBuilders.existsQuery("housenumber")))
                .should(QueryBuilders.matchQuery("housenumber", query).analyzer("standard"))
-                .should(QueryBuilders.existsQuery(String.format("name.%s.raw", language)));


Removing this would seem to partially break querying for objects with names. I added this back and the behaviour seems to be much better.

Thank you! I will do more tests as well.

Author: DavidGorritiGeograma <[email protected]>

juanpelegrina · 2019-11-14T12:34:14Z

Dear @simonpoole,
I would like to know the status of this pull request. Are you planning to accept it? we have been using the code and we have not got any errors.
thanks for your help.
Cheers
Juan

simonpoole · 2019-11-14T12:40:43Z

Dear @simonpoole,
I would like to know the status of this pull request. Are you planning to accept it? we have been using the code and we have not got any errors.
thanks for your help.
Cheers
Juan

Hi Juan

I'm not a maintainer of this repo and wont be able to help directly. @lonvia any input?

lonvia · 2019-11-17T09:48:10Z

I need to find time to review this. Not sure when this will happen.

juanpelegrina · 2019-11-19T09:24:58Z

I need to find time to review this. Not sure when this will happen.

Thanks @lonvia is there any way we can help you? @DavidGorritiGeograma @danielnavarrogeo and I have been involved in the development. We are interested in the improvement, let us know how we can collaborate.

Cheers
Juan

lonvia · 2019-11-19T18:57:59Z

Do you mind rebasing it on the latest master and force-push then new version? That would help.

DavidGorritiGeograma · 2019-11-22T13:46:44Z

Do you mind rebasing it on the latest master and force-push then new version? That would help.

Hello @lonvia, we have rebased our code with the latest fix for the test.
Thanks a lot for your help!
David

otbutz · 2019-11-22T13:57:38Z

src/main/java/de/komoot/photon/query/.gitignore

@@ -0,0 +1 @@
+/PhotonQueryBuilderBackup.java


Putting java files in gitignore seems wrong

Hello, I deleted the .gitignore file.
Thank you very much!
David

juanpelegrina · 2019-12-10T10:50:15Z

Hi @lonvia,
Could be possible to accept this pull request?
Regards
Juan

DavidGorritiGeograma · 2021-01-20T10:01:49Z

Dear @lonvia,

We have been working locally with the solution which we developed in this PR, and we can confirm the results improve. We have been testing our proposal and we would like to share with you the results. Please check on this map the results of our testing

https://www.google.com/maps/d/viewer?mid=1JSQEeEBy0VyQRB2BOjo3RgNnXO1N4vF1&ll=54.45751685160265%2C15.605748222341717&z=4

Thanks for your comment and advice!
David

lonvia · 2021-01-20T20:06:41Z

I have looked into this over Christmas. As far as I can see, the flaky housenumbers come from a different issue. We don't handle mixed-ligual searches very well Pretty much what #496 describes. Housenumbers are always in the original name while other parts tend to come from the language-specific parts. That's why they get hit by this more often.

I've looked through some of the examples from your Google document and as far as I can see the problem with them is that other parts of the address are missing in the database. The second round in your PR is more lenient with that.

I think that your approach with a second round has merit but I'd like to see the mixed-lingual problem solved first. I've experimented with multi-match on this branch. It fixed pretty much all the bug reports except for #227. And I still have to track down what the issue with that is.

lonvia · 2022-02-17T09:44:22Z

Last years changes to the search algorithm have vastly improved the behaviour wrt house numbers. So closing here.

DavidGorritiGeograma added 2 commits March 14, 2019 10:21

Fix for the house number cause the erratic behaviour, e.g. we received a

cd9cec3

golf course hole in Australia instead of an adress in Austria.

Change test expectation in json_queries.

7ee4f8a

simonpoole reviewed Apr 8, 2019

View reviewed changes

Update PhotonQueryBuilder.java

7679466

simonpoole reviewed Apr 8, 2019

View reviewed changes

simonpoole mentioned this pull request Apr 11, 2019

Structurized search by address #405

Closed

DavidGorritiGeograma force-pushed the master branch from 61fd728 to 7679466 Compare September 24, 2019 15:28

DavidGorritiGeograma and others added 9 commits September 24, 2019 17:38

Modification V9 for 0.3.1 Official Release

ece326d

Modification V10 for 0.3.1 Official Release

199ba50

Modification V11 for 0.3.1 Official Release

571af0c

Change for v11

69fcb13

Modify query and test files

95a337f

Modification V11 for 0.3.1 Official Release

4d9b2cd

Change for v11

0f6777e

Author: DavidGorritiGeograma <[email protected]>

Modify query and test files for merge

d9f0d2f

merge code

43fd648

DavidGorritiGeograma force-pushed the master branch from 43fd648 to d9f0d2f Compare September 26, 2019 08:21

DavidGorritiGeograma and others added 2 commits November 20, 2019 11:33

Merge branch 'master' into master

69fd1ed

Modify the test target values in TagFilterQueryBuilderSearchTests

7cc3583

otbutz reviewed Nov 22, 2019

View reviewed changes

Delete unused .gitignore

e153af3

lonvia closed this Feb 17, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix for the house number cause the erratic behaviour #391

Fix for the house number cause the erratic behaviour #391

DavidGorritiGeograma commented Mar 14, 2019 •

edited

Loading

simonpoole Apr 8, 2019 •

edited

Loading

DavidGorritiGeograma Apr 8, 2019

simonpoole Apr 8, 2019

DavidGorritiGeograma Apr 8, 2019

simonpoole Apr 8, 2019 •

edited

Loading

DavidGorritiGeograma Apr 9, 2019

juanpelegrina commented Nov 14, 2019

simonpoole commented Nov 14, 2019

lonvia commented Nov 17, 2019

juanpelegrina commented Nov 19, 2019

lonvia commented Nov 19, 2019

DavidGorritiGeograma commented Nov 22, 2019

otbutz Nov 22, 2019

DavidGorritiGeograma Nov 25, 2019

juanpelegrina commented Dec 10, 2019

DavidGorritiGeograma commented Jan 20, 2021

lonvia commented Jan 20, 2021

lonvia commented Feb 17, 2022 •

edited

Loading

		@@ -0,0 +1 @@
		/PhotonQueryBuilderBackup.java

Fix for the house number cause the erratic behaviour #391

Fix for the house number cause the erratic behaviour #391

Conversation

DavidGorritiGeograma commented Mar 14, 2019 • edited Loading

simonpoole Apr 8, 2019 • edited Loading

Choose a reason for hiding this comment

DavidGorritiGeograma Apr 8, 2019

Choose a reason for hiding this comment

simonpoole Apr 8, 2019

Choose a reason for hiding this comment

DavidGorritiGeograma Apr 8, 2019

Choose a reason for hiding this comment

simonpoole Apr 8, 2019 • edited Loading

Choose a reason for hiding this comment

DavidGorritiGeograma Apr 9, 2019

Choose a reason for hiding this comment

juanpelegrina commented Nov 14, 2019

simonpoole commented Nov 14, 2019

lonvia commented Nov 17, 2019

juanpelegrina commented Nov 19, 2019

lonvia commented Nov 19, 2019

DavidGorritiGeograma commented Nov 22, 2019

otbutz Nov 22, 2019

Choose a reason for hiding this comment

DavidGorritiGeograma Nov 25, 2019

Choose a reason for hiding this comment

juanpelegrina commented Dec 10, 2019

DavidGorritiGeograma commented Jan 20, 2021

lonvia commented Jan 20, 2021

lonvia commented Feb 17, 2022 • edited Loading

DavidGorritiGeograma commented Mar 14, 2019 •

edited

Loading

simonpoole Apr 8, 2019 •

edited

Loading

simonpoole Apr 8, 2019 •

edited

Loading

lonvia commented Feb 17, 2022 •

edited

Loading