Skip to content

Conversation

undera
Copy link
Collaborator

@undera undera commented Mar 7, 2023

Changes Proposed

This is PR to review overall changes for React migration project

Check List

@codecov-commenter
Copy link

codecov-commenter commented May 16, 2023

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (227966b) 29.87% compared to head (d51ac45) 29.85%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #233      +/-   ##
==========================================
- Coverage   29.87%   29.85%   -0.02%     
==========================================
  Files          10       10              
  Lines        1339     1323      -16     
==========================================
- Hits          400      395       -5     
+ Misses        900      887      -13     
- Partials       39       41       +2     
Files Coverage Δ
pkg/dashboard/objects/data.go 11.97% <ø> (+0.16%) ⬆️
pkg/dashboard/server.go 15.06% <ø> (+1.23%) ⬆️
pkg/dashboard/api.go 58.27% <48.38%> (-2.91%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@undera
Copy link
Collaborator Author

undera commented Sep 25, 2023

Please don't close this PR as I use it as general tracking for V2

@undera undera merged commit e4240ed into main Sep 26, 2023
@undera undera deleted the helm-dashboard-v2 branch September 26, 2023 08:21
@undera
Copy link
Collaborator Author

undera commented Sep 26, 2023

Thanks everyone for this 7-month effort!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants