Revert "trace_class add tracing for classmethod and staticmethdod (#115)" #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…)" This reverts commit 5a6fc08. But leaves some of the tests.
gbbirkisson
approved these changes
Aug 9, 2023
|
Tested. The issue is gone and looks to work. |
EeroPaukkonen
deleted the
eerop/revert-trace_class-classmethod-and-static-method
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 5a6fc08. But leaves some of the tests.
staticmethods and classmethods did not work at all. Same with async. Fixing the issues seemed like enough pain that reverting at least for now.