Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: moved upload embeddings out of experimental #754

Conversation

brianshen3
Copy link
Contributor

@brianshen3 brianshen3 commented Feb 7, 2025

Linked issue(s)

KOL-7957

What change does this PR introduce and why?

Move upload_dataset_embeddings out of _experimental

Please check if the PR fulfills these requirements

  • Include reference to internal ticket and/or GitHub issue "Fixes #NNNN" (if applicable)
  • Relevant tests for the changes have been added
  • Relevant docs have been added / updated (Going to do this separate PR/ticket)

@brianshen3 brianshen3 requested a review from a team as a code owner February 7, 2025 21:46
@brianshen3 brianshen3 changed the title draft: moved upload embeddings out of experimental chore: moved upload embeddings out of experimental Feb 7, 2025
@brianshen3 brianshen3 requested a review from nankolena February 10, 2025 15:45
Copy link
Contributor

@nankolena nankolena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you are missing some changes to the docs index too because it's currently still shown under the experimental page. Probably need to remove this block and check if you need to add anything for the dataset page

image

@brianshen3
Copy link
Contributor Author

I think you are missing some changes to the docs index too because it's currently still shown under the experimental page. Probably need to remove this block and check if you need to add anything for the dataset page

image

Updated to show properly under dataset. Removed showing from experimental to avoid confusion and follow current doc behaviour.

@brianshen3 brianshen3 requested a review from nankolena February 10, 2025 19:19
@brianshen3 brianshen3 requested a review from nankolena February 12, 2025 15:50
Copy link
Contributor

@nankolena nankolena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a couple small nits - should be good once those are addressed!

@brianshen3 brianshen3 requested a review from nankolena February 12, 2025 17:54
@brianshen3 brianshen3 merged commit 4151cdc into trunk Feb 12, 2025
56 checks passed
@brianshen3 brianshen3 deleted the brianshen/kol-7957-move-upload-embeddings-out-of-the-experimental-section branch February 12, 2025 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants