-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: moved upload embeddings out of experimental #754
chore: moved upload embeddings out of experimental #754
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you are missing some changes to the docs index too because it's currently still shown under the experimental page. Probably need to remove this block and check if you need to add anything for the dataset page

Updated to show properly under dataset. Removed showing from experimental to avoid confusion and follow current doc behaviour. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only a couple small nits - should be good once those are addressed!
Linked issue(s)
KOL-7957
What change does this PR introduce and why?
Move
upload_dataset_embeddings
out of _experimentalPlease check if the PR fulfills these requirements