Treat empty prompts and responses as empty strings #100
+19
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## trunk #100 +/- ##
==========================================
- Coverage 96.93% 96.92% -0.01%
==========================================
Files 34 34
Lines 1467 1464 -3
==========================================
- Hits 1422 1419 -3
Misses 45 45 ☔ View full report in Codecov by Sentry. |
| @@ -96,13 +96,10 @@ def upload_responses(project_slug: str, model_name: str, df_response: pd.DataFra | |||
| raise BadRequestError(str(e)) | |||
| if len(df_response) == 0: | |||
| raise BadRequestError("Responses must not be empty") | |||
| df_response = df_response.copy().replace({np.nan: ""}) | |||
There was a problem hiding this comment.
If we ever make use of columns beyond prompt or response, we may want to restrict it to df_response[["prompt", "response"]].
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the handling of model responses to treat empty
promptorresponsecells as empty strings, rather than dropping those rows. This means that:responsevalues are treated as if the model did not return anything, and can be evaluated head-to-head like any other responsepromptvalues are treated as if the user did not input anything, meaning one such row is acceptable per model (under thepromptuniqueness constraint) but uploads with multiple empty prompts are rejected due to duplicate values