Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept sampler designation in sampling of training #906

Merged

Conversation

shirayu
Copy link
Contributor

@shirayu shirayu commented Oct 29, 2023

  • ✨ Main purpose
    • Added --ss or sample_sampler in dict to set another scheduler dynamically in training
  • 🧹 Refactoring
    • Make a function get_my_scheduler() 01e00ac
    • Added a function line_to_prompt_dict() and removed duplicated initialization: 01e00ac

💭 Things to be considered

  • To remove duplicated codes in gen_img_diffusers.py and sdxl_gen_img.py by using new get_my_scheduler() and line_to_prompt_dict()
    • I tried to do this at the same time, but it seems to require a big change, so I only made this small change (Add --ss in training) for this pull request

@kohya-ss kohya-ss merged commit df59822 into kohya-ss:dev Dec 3, 2023
1 check passed
@kohya-ss
Copy link
Owner

kohya-ss commented Dec 3, 2023

Thank you for this. This is really useful!

@shirayu shirayu deleted the accept_scheduler_designation_in_training branch December 3, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants