Add OnlyOnInclude option for the root rewritter #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like this, though I'm somewhat in doubt if this is really desired. By default in EF you'll get all properties when you select an Entity. If you want to select a subset then you'll have to be explicit about this. This turns that logic around, (you won't get it unless you explicitly ask for it). Granted this is already the case when it comes to including relationships... |
zoriya
force-pushed
the
feat/includes
branch
2 times, most recently
from
66b19a6 to
ec7c478
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows projectable properties to be marked as
OnlyOnIncludeand only opt-in root query rewriting by explicitly calling a.Include(x => x.ProjectedProperty). This was discussed in #84 by @yinzara.PS: maybe this should be the default mode for root query rewriting?
(PR based on #90)