Skip to content

Fix flaky Playwright e2e coverage #950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cursor merged 1 commit into from
Jul 25, 2026
Merged

Fix flaky Playwright e2e coverage #950

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 0 additions & 26 deletions e2e/account-jobs.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,32 +3,6 @@ import { quoteSqlString } from '@kody-internal/shared/sql-literals.ts'
import { createStableUserIdFromEmail } from '../packages/worker/src/user-id.ts'
import { executeE2eD1Command } from './d1-utils.ts'

test('account jobs page shows heading after login', async ({
page,
seedE2eUser,
login,
}) => {
const runId = Date.now()
const user = await seedE2eUser({
email: `account-jobs-${runId}@example.com`,
username: `account-jobs-${runId}`,
password: 'account-jobs-password',
})
await login({
email: user.email,
password: user.password,
mode: 'login',
})

await page.goto('/account/jobs')
await expect(
page.getByRole('heading', { name: 'Jobs', exact: true }),
).toBeVisible()
await expect(
page.getByRole('heading', { name: 'Select a job', exact: true }),
).toBeVisible()
})

test('account jobs detail URL persists across reload for a seeded job', async ({
page,
seedE2eUser,
Expand Down
26 changes: 0 additions & 26 deletions e2e/account-memories.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,32 +3,6 @@ import { quoteSqlString } from '@kody-internal/shared/sql-literals.ts'
import { createStableUserIdFromEmail } from '../packages/worker/src/user-id.ts'
import { executeE2eD1Command } from './d1-utils.ts'

test('account memories list shows empty state', async ({
page,
seedE2eUser,
login,
}) => {
const runId = Date.now()
const user = await seedE2eUser({
email: `account-memories-${runId}@example.com`,
username: `account-memories-${runId}`,
password: 'account-memories-password',
})
await login({
email: user.email,
password: user.password,
mode: 'login',
})

await page.goto('/account/memories')
await expect(
page.getByRole('heading', { name: 'Memories', exact: true }),
).toBeVisible()
await expect(
page.getByRole('heading', { name: 'Select a memory', exact: true }),
).toBeVisible()
})

test('account memories detail URL shows a seeded memory', async ({
page,
seedE2eUser,
Expand Down
79 changes: 33 additions & 46 deletions e2e/passkeys.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,18 @@ function localhostUrl(baseURL: string | undefined, pathname: string) {
return url.toString()
}

async function gotoLocalhost(
page: Page,
baseURL: string | undefined,
pathname: string,
) {
// Prefer domcontentloaded: under CI load the full `load` event can stall on
// late assets while the app shell is already interactive.
await page.goto(localhostUrl(baseURL, pathname), {
waitUntil: 'domcontentloaded',
})
}

async function addVirtualAuthenticator(page: Page) {
const client = await page.context().newCDPSession(page)
await client.send('WebAuthn.enable')
Expand All @@ -26,7 +38,7 @@ async function addVirtualAuthenticator(page: Page) {
})
}

test('passkey lifecycle: register, sign in, delete', async ({
test('passkey lifecycle: register, skip TOTP when 2FA enabled, sign in, delete', async ({
page,
seedE2eUser,
login,
Expand All @@ -39,10 +51,13 @@ test('passkey lifecycle: register, sign in, delete', async ({
password: 'passkey-password',
})
await login({ email: user.email, password: user.password, mode: 'login' })
// Cross from the 127.0.0.1 API origin onto localhost before WebAuthn work so
// later relative navigations stay on the relying-party domain.
await gotoLocalhost(page, baseURL, '/account')
await addVirtualAuthenticator(page)

// Register a passkey from account settings.
await page.goto(localhostUrl(baseURL, '/account/passkeys'))
await gotoLocalhost(page, baseURL, '/account/passkeys')
await expect(
page.getByRole('heading', { name: 'No passkeys yet' }),
).toBeVisible()
Expand All @@ -64,43 +79,8 @@ test('passkey lifecycle: register, sign in, delete', async ({
await expect(page.getByText('Passkey renamed.')).toBeVisible()
await expect(passkeyList.getByText('Josh phone')).toBeVisible()

// Sign in with the passkey instead of the password.
await page.context().clearCookies()
clearAuthRateLimitsInE2eDatabase()
await page.goto(localhostUrl(baseURL, '/login'))
await page.getByRole('button', { name: 'Sign in with a passkey' }).click()
await expect(page).toHaveURL(/\/account$/)
await expect(page.getByText(`Email: ${user.email}`)).toBeVisible()

// Delete the passkey.
await page.goto(localhostUrl(baseURL, '/account/passkeys'))
await expect(passkeyList.getByText('Josh phone')).toBeVisible()
await expect(passkeyList.getByText(/Last used /)).toBeVisible()
await expect(passkeyList.getByText('Last used Never')).toHaveCount(0)
await page.getByRole('button', { name: 'Delete' }).click()
await expect(page.getByText('Passkey deleted.')).toBeVisible()
await expect(
page.getByRole('heading', { name: 'No passkeys yet' }),
).toBeVisible()
})

test('passkey sign-in skips TOTP when two-factor is enabled', async ({
page,
seedE2eUser,
login,
baseURL,
}) => {
const runId = Date.now()
const user = await seedE2eUser({
email: `passkey-2fa-${runId}@example.com`,
username: `passkey-2fa-${runId}`,
password: 'passkey-2fa-password',
})
await login({ email: user.email, password: user.password, mode: 'login' })
await addVirtualAuthenticator(page)

// Enable 2FA.
await page.goto(localhostUrl(baseURL, '/account/two-factor'))
// Enable 2FA: a verified passkey must still skip the TOTP challenge.
await gotoLocalhost(page, baseURL, '/account/two-factor')
await page.getByRole('button', { name: 'Enable 2FA' }).click()
const secret = (await page.getByTestId('totp-secret').textContent()) ?? ''
expect(secret.length).toBeGreaterThan(0)
Expand All @@ -112,16 +92,23 @@ test('passkey sign-in skips TOTP when two-factor is enabled', async ({
page.getByText('Two-factor authentication is enabled.'),
).toBeVisible()

// Register a passkey.
await page.goto(localhostUrl(baseURL, '/account/passkeys'))
await page.getByRole('button', { name: 'Register a passkey' }).click()
await expect(page.getByText('Passkey registered.')).toBeVisible()

// A verified passkey already satisfies MFA, so skip the TOTP challenge.
// Sign in with the passkey instead of the password; land on /account, not
// /verify.
await page.context().clearCookies()
clearAuthRateLimitsInE2eDatabase()
await page.goto(localhostUrl(baseURL, '/login'))
await gotoLocalhost(page, baseURL, '/login')
await page.getByRole('button', { name: 'Sign in with a passkey' }).click()
await expect(page).toHaveURL(/\/account$/)
await expect(page.getByText(`Email: ${user.email}`)).toBeVisible()

// Delete the passkey.
await gotoLocalhost(page, baseURL, '/account/passkeys')
await expect(passkeyList.getByText('Josh phone')).toBeVisible()
await expect(passkeyList.getByText(/Last used /)).toBeVisible()
await expect(passkeyList.getByText('Last used Never')).toHaveCount(0)
await page.getByRole('button', { name: 'Delete' }).click()
await expect(page.getByText('Passkey deleted.')).toBeVisible()
await expect(
page.getByRole('heading', { name: 'No passkeys yet' }),
).toBeVisible()
})
83 changes: 0 additions & 83 deletions e2e/scroll-restore-slow-frame.spec.ts
View file
Open in desktop

This file was deleted.

Loading