[kentcdodds]

Summary

• replace hand-maintained Vitest include lists with suffix-based globs for node, workers, and MCP E2E projects
• rename existing tests so each file opts into its Vitest project via filename convention, including new node-side tests added on main
• update docs, tooling references, and the newly surfaced client test assertion to match the new convention

Testing

• npm run test
• npm run test:mcp

  

Summary by CodeRabbit

• Chores
  • Streamlined testing infrastructure by standardizing test file naming conventions and updating configuration patterns for consistency across the codebase.
  • Updated documentation to reflect new testing guidelines and file organization standards for developers.

[coderabbitai]

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

This PR refactors Vitest test discovery from explicit file path listings to convention-based filename suffixes (.node.test.ts, .workers.test.ts, .mcp-e2e.test.ts), updates documentation to reflect the new naming patterns, and modifies related TypeScript and test tooling configuration accordingly.

Changes

Cohort / File(s)	Summary
Documentation Updates docs/agents/adding-capabilities.md, docs/agents/testing-principles.md, docs/agents/typescript-setup.md	Updated guidance to reflect new MCP E2E test filename pattern and documented how filename suffixes map to Vitest projects.
Vitest Configuration vitest.node.config.ts, vitest.workers.config.ts, vitest.mcp-e2e.config.ts	Replaced explicit file path lists with glob patterns matching filename conventions (e.g., **/*.node.test.ts, **/*.workers.test.ts, **/*.mcp-e2e.test.ts).
TypeScript Tooling Configuration tsconfig-tools.json	Updated include glob to reference new MCP E2E test file naming pattern.
Package Configuration packages/home-connector/package.json	Updated Vitest target path in test script from packages/home-connector/src to packages/home-connector.
Test Logic Update packages/worker/client/app-session-refresh.node.test.ts	Changed UI rendering from synchronous String(render()) to asynchronous renderToString(render()).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

• Add parameterized saved apps #63: Modifies Vitest test discovery configuration and MCP end-to-end test file patterns using the same suffix-based naming conventions.
• Move worker env typing and tsconfig ownership into packages #39: Modifies tsconfig-tools.json include globs and affects which test files are picked up by TypeScript configuration.
• fix(test): bootstrap env for MCP e2e #32: Uses the updated MCP E2E test path conventions in test discovery and execution scripts.

Poem

🐰 Hop-hop, a naming convention takes flight,
Suffixes guide tests through day and night,
From explicit paths to glob-based grace,
Discovery quickens across codespace!
Tests organized, configs made neat—
Convention-driven, what a sweet feat! 🎉

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically describes the main change: adopting suffix-based routing for Vitest test file discovery.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch cursor/vitest-test-file-patterns-665a

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[kentcdodds]

@cursor, please rebase on main and make necessary adjustments based on the changes in main.

[cursor]

Summary

• Rebased cursor/vitest-test-file-patterns-665a onto the latest origin/main, resolved the vitest.node.config.ts conflict in favor of the suffix-glob convention, and force-pushed the rebased branch.
• Folded in the new Node-side tests that landed on main by renaming them into the convention as run-codemode-registry.node.test.ts and packages/worker/src/mcp/secrets/*.node.test.ts, so the rebased branch keeps that newer coverage. vitest.node.config.ts:29-33 run-codemode-registry.node.test.ts:1-93 capability-inputs.node.test.ts:1-78 errors.node.test.ts:1-37
• Kept the supporting tooling/docs aligned with the rebased test naming, including the MCP tools tsconfig reference. tsconfig-tools.json:29-38

Testing

• No manual UI testing was needed because this was a git rebase plus test-file convention maintenance; the relevant validation is the targeted Vitest coverage on the rebased branch.
• ✅ npm run test — verified the rebased node-unit and workers-unit projects pass with the updated convention, now covering 46 files and 159 tests after absorbing the new tests from main. terminal:1-54
• ✅ npm run test:mcp — verified the dedicated MCP E2E project still discovers and runs the .mcp-e2e.test.ts file on the rebased branch. terminal:1-21

  

[github-actions]

🔎 Preview deployed: https://kody-pr-67.kentcdodds.workers.dev

Worker: kody-pr-67
D1: kody-pr-67-db
KV: kody-pr-67-oauth-kv

Mocks:

• ai: https://kody-pr-67-mock-ai.kentcdodds.workers.dev/__mocks (kody-pr-67-mock-ai)
• cloudflare: https://kody-pr-67-mock-cloudflare.kentcdodds.workers.dev/__mocks (kody-pr-67-mock-cloudflare)
• cursor: https://kody-pr-67-mock-cursor.kentcdodds.workers.dev/__mocks (kody-pr-67-mock-cursor)
• github: https://kody-pr-67-mock-github.kentcdodds.workers.dev/__mocks (kody-pr-67-mock-github)
• resend: https://kody-pr-67-mock-resend.kentcdodds.workers.dev/__mocks (kody-pr-67-mock-resend)