Repository navigation
Enable package invocation from execute - #471
Conversation
Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughThis PR extends dynamic package invocation to authenticated ad-hoc execute calls by introducing an execute-runtime invocation path. The changes enable ChangesExecute-runtime Package Invocation
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related issues
Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
🔎 Preview deployed: https://kody-pr-471.kentcdodds.workers.dev Worker: Mocks:
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/use/execute.md`:
- Around line 39-43: The docs are inconsistent about whether the runtime
`packages` API is available in authenticated ad hoc execute flows; update the
later section that currently claims `packages` is null in ad hoc static-import
flows to match the earlier statement that authenticated ad hoc execute exposes
`packages.*`. Edit the paragraph(s) referencing "ad hoc execute static-import
flows" and clarify that when the execute is authenticated you can import and use
`packages` (e.g. `packages.check`, `packages.invoke`, `packages.invokeChecked`),
and keep the guidance to prefer `packages.invokeChecked` unless you already
called `check` and are passing `check.invoke`; ensure both mentions use the same
wording so behavior is documented consistently.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 1384ade5-103d-444a-a8aa-f0f61cce97fb
📒 Files selected for processing (9)
docs/contributing/packages-and-manifests.mddocs/use/execute.mddocs/use/packages.mdpackages/worker/src/mcp/server-instructions.tspackages/worker/src/mcp/tools/execute.node.test.tspackages/worker/src/mcp/tools/execute.tspackages/worker/src/package-invocations/service.node.test.tspackages/worker/src/package-invocations/service.tspackages/worker/src/package-runtime/module-graph.workers.test.ts
Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
|
Caution Review failedAn error occurred during the review process. Please try again later. 📝 WalkthroughWalkthroughThis PR extends dynamic package invocation to authenticated ad-hoc execute calls by introducing an execute-runtime invocation path. The changes enable ChangesExecute-runtime Package Invocation
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related issues
Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
packages.check,packages.invoke, andpackages.invokeCheckedin authenticated ad hocexecutecalls.source: "execute", unique auto idempotency, same-user package resolution, and normal target package runtime context.kody:@...imports as library/snapshot imports, and update docs/tool instructions to explain the distinction.Testing
npx vitest run --project node-unit packages/worker/src/mcp/tools/execute.node.test.ts packages/worker/src/package-invocations/service.node.test.ts -t "execute|package runtime checks and invokes|invokeChecked"npx vitest run --project workers-unit packages/worker/src/package-runtime/module-graph.workers.test.ts -t "packages"npm run validateSummary by CodeRabbit
New Features
Documentation
Tests