Skip to content

Tighten manifest export document assertions - #465

Merged
kentcdodds merged 1 commit into
mainfrom
cursor/fix-manifest-export-assertions-5d76
May 13, 2026
Merged

kentcdodds merged 1 commit into
mainfrom
cursor/fix-manifest-export-assertions-5d76

Conversation

@kentcdodds

@kentcdodds kentcdodds commented May 13, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Replace empty-string fallback document assertions with concrete export text checks in the manifest package-registry test.

Testing

  • npx vitest run --project node-unit packages/worker/src/package-registry/manifest.node.test.ts
  • npm run validate
Open in Web Open in Cursor 

Summary by CodeRabbit

  • Tests
    • Enhanced test coverage for package search documentation by improving verification that exported functions, their names, and associated documentation are properly indexed and captured in search results. These strengthened assertions ensure the search system remains reliable and continues to accurately help users discover, identify, and understand available functions and their capabilities.

Review Change Stack

Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
@coderabbitai

coderabbitai Bot commented May 13, 2026 •

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 39a9069c-83fa-4d57-87d2-ad77fbc7db41

📥 Commits

Reviewing files that changed from the base of the PR and between 65f8ebf and bc33699.

📒 Files selected for processing (1)
  • packages/worker/src/package-registry/manifest.node.test.ts

📝 Walkthrough

Walkthrough

The buildPackageSearchDocument test is updated to assert more precise content in the generated document. It now verifies the exported surface mapping for source and declaration files, the forecast function name, and its JSDoc text, while removing assertions tied to the older projection.exports structure.

Changes

Search Document Test Assertions

Layer / File(s) Summary
buildPackageSearchDocument test assertions
packages/worker/src/package-registry/manifest.node.test.ts
Test assertions are refined to directly check the document includes the exported surface mapping for src/index.ts/src/index.d.ts, the forecast API function name, and its JSDoc text, replacing older exportDetail and exportedFunction checks derived from projection.exports.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

  • kentcdodds/kody#382: Updates to buildPackageSearchDocument test expectations are driven by the referencedTypes/export metadata contract changes in the manifest generation logic.
  • kentcdodds/kody#383: The test assertions align with the addition of package export surface projection and kody: import specifier construction for package detail formatting.

Poem

A rabbit hops through assertions fine,
Checking exports in a tidy line.
Old checks fade, new ones shine bright,
The forecast function gleams just right! 🐰✨

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cursor/fix-manifest-export-assertions-5d76

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kentcdodds
kentcdodds marked this pull request as ready for review May 13, 2026 13:07
@kentcdodds
kentcdodds merged commit 82dc3a9 into main May 13, 2026
4 checks passed
@kody-bot
kody-bot deleted the cursor/fix-manifest-export-assertions-5d76 branch July 21, 2026 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants