Skip to content

chore: move workspace-owned dependencies - #164

Merged
kentcdodds merged 1 commit into
mainfrom
cursor/move-package-deps-a5e7
Apr 13, 2026
Merged

kentcdodds merged 1 commit into
mainfrom
cursor/move-package-deps-a5e7

Conversation

@kentcdodds

@kentcdodds kentcdodds commented Apr 13, 2026 •

Copy link
Copy Markdown
Member

Summary

  • move worker runtime dependencies out of the repo root and into packages/worker
  • add the missing remix declaration to packages/mock-servers/cloudflare
  • keep only root-owned script/test tooling in the root manifest and refresh the lockfile on top of latest main

Testing

  • npm run typecheck
  • npx vitest run --config vitest.node.config.ts packages/worker/src/mcp/cloudflare/cloudflare-rest-client.node.test.ts packages/worker/src/app/email/cloudflare-email.node.test.ts packages/worker/src/mcp/capabilities/coding/coding-capabilities.node.test.ts tools/seed-test-data.node.test.ts tools/home-connector-env.node.test.ts tools/ci/sync-worker-secrets.node.test.ts packages/home-connector/src/mcp/server.node.test.ts
  • git push --force-with-lease -u origin cursor/move-package-deps-a5e7 (pre-push hook passed npm run test && npm run test:e2e:run)
Open in Web Open in Cursor 

Summary by CodeRabbit

  • Chores
    • Reorganized root dependency declarations, separating development-only and runtime packages.
    • Added dev-only tooling and pinned an SDK version for consistency.
    • Expanded runtime dependencies for the worker and mock server packages to enable additional platform and framework capabilities.
    • Updated framework/runtime dependencies across packages for alignment.

@coderabbitai

coderabbitai Bot commented Apr 13, 2026 •

Copy link
Copy Markdown

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: daca4cee-b3d0-419b-9c98-b0038ab0afa9

📥 Commits

Reviewing files that changed from the base of the PR and between 705afa3 and 3b247dd.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (3)
  • package.json
  • packages/mock-servers/cloudflare/package.json
  • packages/worker/package.json
✅ Files skipped from review due to trivial changes (1)
  • packages/mock-servers/cloudflare/package.json
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/worker/package.json

📝 Walkthrough

Walkthrough

Root package dependencies were reorganized (runtime deps removed; some entries moved to devDependencies); mock cloudflare server added remix; worker package gained multiple runtime dependencies including Cloudflare tooling, MCP packages, and various utilities.

Changes

Cohort / File(s) Summary
Root package.json
package.json
Removed the top-level dependencies block; added @kody-internal/shared, @modelcontextprotocol/sdk (pinned 1.29.0), and get-port to devDependencies; kept overrides for @modelcontextprotocol/sdk.
Mock server
packages/mock-servers/cloudflare/package.json
Added runtime dependency remix@3.0.0-alpha.3.
Worker package
packages/worker/package.json
Expanded dependencies to include Cloudflare packages (@cloudflare/ai-chat, @cloudflare/codemode, @cloudflare/workers-oauth-provider), MCP-related packages (@modelcontextprotocol/sdk, @modelcontextprotocol/ext-apps, @mcp-ui/server), Sentry and utilities (@sentry/cloudflare, @epic-web/invariant, acorn, agents, croner, workers-ai-provider, zod), while retaining @kody-internal/shared (file:../shared).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Poem

🐰 I hopped through package.json tonight,
Moved deps and tucked some out of sight.
Remix joined the cloudflare play,
Workers gained new tools to sway.
A tidy hop — dependencies light. ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: moving workspace-owned dependencies from root package.json to packages/worker/package.json, which is the core objective of the PR.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cursor/move-package-deps-a5e7

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kentcdodds
kentcdodds marked this pull request as ready for review April 13, 2026 19:24
@github-actions

Copy link
Copy Markdown
Contributor

🔎 Preview deployed: https://kody-pr-164.kentcdodds.workers.dev

Worker: kody-pr-164
D1: kody-pr-164-db
KV: kody-pr-164-oauth-kv

Mocks:

@cursor
cursor Bot force-pushed the cursor/move-package-deps-a5e7 branch from 705afa3 to 3b247dd Compare April 13, 2026 23:09
@kentcdodds
kentcdodds merged commit 7942f38 into main Apr 13, 2026
2 of 9 checks passed
@kentcdodds
kentcdodds deleted the cursor/move-package-deps-a5e7 branch April 13, 2026 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants