Repository navigation
docs: record completed PackageServiceInstance delete sequence - #1566
kentcdodds wants to merge 1 commit into
Conversation
Garden the runtime-worker runbook and ADR 0025 so they describe the finished two-deploy class delete, and point leftover kind=service inventory purge at #1565. Co-authored-by: me <me@kentcdodds.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The runbook + ADR 0025 gardens here are included in #1569 (leftover-service purge removal). This docs-only PR can close once that lands, or close now as superseded. |
Intent
Keep contributing docs aligned with the finished
PackageServiceInstancedelete, and point leftoverkind='service'storage inventory purge at a tracked issue so it is not forgotten.Summary
PackageServiceInstanceas already deleted on production (v2; no stub).kind='service'inventory is gone, then remove the purge lane).Testing
Docs-only. Relevant local checks passed:
npm run docs:check-temporalnpm run format:checknpm run primitives:checknpm run migrations:checknpm run deploy-guardrails:checkFull
npm run validatewas started; the docs-adjacent jobs above passed. Parallel e2e / mock-API timeouts on this Cloud Agent VM are unrelated to the two markdown files.System changes
Docs only. Wrangler history, deletion allowlist, durable-object baseline, and the leftover-service purge lane are unchanged.
System recap — composes existing primitives (low risk)
Mode: recap · Base:
main@3cd38054· Head:0465d9faClassification: composes — no primitives added or changed; this PR gardens two contributing docs.
Primitives touched
coderootsUnmatched paths:
docs/contributing/architecture/runtime-worker-migration-runbook.md,docs/contributing/decisions/0025-no-package-services-primitive.md.Change flow
Contributors reading the runtime-worker runbook see the completed class-delete state; ADR 0025 points leftover inventory purge at #1565.