Skip to content

docs: record completed PackageServiceInstance delete sequence - #1566

Closed
kentcdodds wants to merge 1 commit into
mainfrom
cursor/package-services-docs-cleanup-8713
Closed

kentcdodds wants to merge 1 commit into
mainfrom
cursor/package-services-docs-cleanup-8713

Conversation

@kentcdodds

@kentcdodds kentcdodds commented Aug 19, 2026 •

Copy link
Copy Markdown
Member

Intent

Keep contributing docs aligned with the finished PackageServiceInstance delete, and point leftover kind='service' storage inventory purge at a tracked issue so it is not forgotten.

Summary

Testing

Docs-only. Relevant local checks passed:

  • npm run docs:check-temporal
  • npm run format:check
  • npm run primitives:check
  • npm run migrations:check
  • npm run deploy-guardrails:check

Full npm run validate was started; the docs-adjacent jobs above passed. Parallel e2e / mock-API timeouts on this Cloud Agent VM are unrelated to the two markdown files.

System changes

Docs only. Wrangler history, deletion allowlist, durable-object baseline, and the leftover-service purge lane are unchanged.

System recap — composes existing primitives (low risk)

Mode: recap · Base: main @ 3cd38054 · Head: 0465d9fa

Classification: composes — no primitives added or changed; this PR gardens two contributing docs.

Primitives touched

Primitive Group Impact
(none) — docs-only; classifier matched no code roots

Unmatched paths: docs/contributing/architecture/runtime-worker-migration-runbook.md, docs/contributing/decisions/0025-no-package-services-primitive.md.

Change flow

Contributors reading the runtime-worker runbook see the completed class-delete state; ADR 0025 points leftover inventory purge at #1565.

sequenceDiagram
	actor Contributor
	participant runbook as runtime-worker-migration-runbook
	participant adr as adr-0025
	Contributor->>runbook: read Deleting a transferred class
	Note over runbook: PackageServiceInstance gone on production (v2; no stub)
	Contributor->>adr: read 0025 consequences
	Note over adr: leftover kind=service purge tracked in #1565
Loading
Open in Web Open in Cursor 

Garden the runtime-worker runbook and ADR 0025 so they describe the
finished two-deploy class delete, and point leftover kind=service
inventory purge at #1565.

Co-authored-by: me <me@kentcdodds.com>
@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 36a2edb3-9f08-4453-bfb5-59241a7bbba6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kody-bot

Copy link
Copy Markdown
Member

The runbook + ADR 0025 gardens here are included in #1569 (leftover-service purge removal). This docs-only PR can close once that lands, or close now as superseded.

@kentcdodds kentcdodds closed this Aug 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants