Skip to content

Delete PackageServiceInstance on kody-runtime #1560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kody-bot merged 1 commit into from
Aug 19, 2026
Merged

Delete PackageServiceInstance on kody-runtime #1560

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions docs/contributing/architecture/runtime-worker-migration-runbook.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,11 +176,9 @@ the class until `deleted_classes` runs (error 10064). Export a stub, drop the
binding, then add the `deleted_classes` migration and its
`tools/ci/do-deletion-allowlist.json` entry on a later deploy.

`PackageServiceInstance` is in that window: the runtime worker exports a stub
and omits tag `v2` so production can drop the remote binding. Preview also omits
`v2` while the stub is exported; `deleted_classes` fails with error 10074 when
the previous script version did not export the class. The allowlist entry stays
for the follow-up that restores `v2` and removes the stub.
`PackageServiceInstance` uses that sequence: production `kody-runtime` applies
tag `v2` after a stub-export deploy dropped the transferred binding. Preview
applies `v1` `new_sqlite_classes` then `v2` `deleted_classes` on first deploy.

## Rollback

Expand Down
8 changes: 4 additions & 4 deletions docs/contributing/decisions/0025-no-package-services-primitive.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ has a remote binding and existing objects after the source binding is gone. A
same-deploy `deleted_classes` migration fails with error 10061. Dropping the
binding without exporting the class fails with error 10064. Export a stub, drop
the remote binding, then apply runtime-worker tag `v2` `deleted_classes` and
remove the stub. The `tools/ci/do-deletion-allowlist.json` entry for that tag
stays for the follow-up. Preview also omits `v2` while the stub is exported:
`deleted_classes` fails with error 10074 when the previous script version did
not export the class.
remove the stub. #1559 completed the stub-and-drop-binding deploy. The
`tools/ci/do-deletion-allowlist.json` entry for tag `v2` is the contract for the
class-delete follow-up. Preview `deleted_classes` requires a previous script
version that exported the class (error 10074).
15 changes: 8 additions & 7 deletions packages/runtime-worker/wrangler.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,13 +74,10 @@
},
],
},
// Production still has transferred PackageServiceInstance
// objects. deleted_classes while the remote binding exists is
// error 10061; dropping the binding without exporting the class
// is error 10064. Export the stub and omit the binding here.
// Add tag v2 after this deploy. Preview also omits v2: a
// delete-class on a script whose previous version did not
// export the class is error 10074.
{
"tag": "v2",
"deleted_classes": ["PackageServiceInstance"],
},
],
"observability": {
"enabled": true,
Expand Down Expand Up @@ -270,6 +267,10 @@
"PackageServiceInstance",
],
},
{
"tag": "v2",
"deleted_classes": ["PackageServiceInstance"],
},
],
"worker_loaders": [
{
Expand Down
9 changes: 0 additions & 9 deletions packages/worker/src/package-service-instance-stub.ts
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions packages/worker/src/runtime-worker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import {
} from '@kody-internal/shared/runtime-worker.ts'
import { StorageRunner } from './storage-runner.ts'
import { RunLog } from './run-records/run-log-do.ts'
import { PackageServiceInstance } from './package-service-instance-stub.ts'
import { PackageRealtimeSession } from '#worker/package-runtime/realtime-session.ts'
import { DynamicCallableWorkflow } from '#worker/package-runtime/package-workflows.ts'
import { PackageAppRuntimeBridge } from '#worker/package-runtime/package-app.ts'
Expand Down Expand Up @@ -42,7 +41,6 @@ export {
StorageRunner,
RunLog,
PackageRealtimeSession,
PackageServiceInstance,
DynamicCallableWorkflow,
PackageAppRuntimeBridge,
KodyFetchGateway,
Expand Down
Loading