Repository navigation
fix(mcp): protect ready callback recovery - #1464
Conversation
Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
…tps://github.com/kentcdodds/kody into cursor/mcp-oauth-self-heal-for-domain-state-700e Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
…-heal-for-domain-state-700e Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
|
Warning Review limit reached
Next review available in: 30 minutes Limit details: You’ve used all 2 included reviews currently available under your plan. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit cf89e6c. Configure here.
|
🔎 Preview deployed: https://kody-pr-1464.kody-a99.workers.dev Worker: Mocks:
|
Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>

Intent
Fix late Bugbot findings from #1462 without interrupting already-authorized remote MCP connections or promising a replacement authorization link when Kody could not identify a server.
Summary
Testing
npx vitest run --project node-unit packages/worker/src/mcp-client/hub-oauth-recovery.node.test.ts packages/worker/src/mcp-client/oauth-callback-outcome.node.test.ts packages/worker/src/app/handlers/account-mcp-servers.node.test.ts(11 passed)npm run typechecknpm run format:checknpm run lintkody-pr-1464at9661e2db: signed in as the non-admin seed user, added the preview itself as an OAuth-protected MCP server, approved access, and confirmed it reached Connected with 2 tools.System changes
System recap — extends existing primitives (medium risk)
Mode: recap · Base:
main@bfaf1ad8· Head:9661e2dbClassification: extends — tightens remote MCP callback recovery behavior and account UI messaging; no new primitive is added.
Primitives touched
mcp-client-serversapp-uiSystem map
Callback recovery checks the existing per-user MCP connection before deciding whether to restart OAuth, then selects UI copy that matches whether a new link exists.
Legend: green = composes (wiring only) · amber = extended by this PR · red = new primitive · gray = context (unchanged, included only when an edge crosses it).
Invariants