Repository navigation
fix(status): keep uptime bars inside cards on mobile - #1236
Conversation
90 day bars used min-width:2px plus gaps, which overflowed card padding on iPhone-width screens. Allow bars to shrink and clip the row instead. Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughThe status page now supports narrow layouts by shrinking chart content, hiding overflow, and wrapping legend text. Inbound due-work calculations now accept and propagate an optional reference timestamp. ChangesResponsive status layout
Time-aware inbound scheduling
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant ReconcileInboundDeliveries
participant MailboxCoreRpc
participant MailboxInboundCommands
participant InboundDueOwners
ReconcileInboundDeliveries->>MailboxCoreRpc: pass now as ISO timestamp
MailboxCoreRpc->>MailboxInboundCommands: forward ownerId and optional now
MailboxInboundCommands->>InboundDueOwners: call getMailboxInboundDueAt with Date
InboundDueOwners-->>MailboxInboundCommands: return due timestamp or null
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
bugbot run |
|
Skipping Bugbot: Unable to authenticate your request. Please make sure Bugbot is properly installed and configured for this repository. |
|
🔎 Preview deployed: https://kody-pr-1236.kody-a99.workers.dev Worker: Mocks:
|
|
Bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit c1d4b12. Configure here.
getMailboxInboundDueAt used wall-clock Date.now() for the stale-delivery floor, so sweeps that pass a frozen now could still clamp to wall time once created_at+48h fell behind the real clock (broke CI on 2026-08-05). Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
Prefer an optional Date parameter over a defaulted required one so undefined callers type-check cleanly. Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
Summary
On iPhone-width viewports, the 90-day uptime bars on status.heykody.dev overflowed past the card edge (reported in https://x.com/i/status/2084909856432275934).
Each bar had
min-width: 2pxwith a 2px gap, so 90 days needed ~358px while the card content area is only ~321px after page/card padding. Bars now shrink (min-width: 0) and the row clips inside the card.Also unblocks Workers CI:
getMailboxInboundDueAtwas clamping stale delivery due-ats with wall-clockDate.now()even when sweeps injected a frozennow, so once real time passed the fixture’screated_at+48hthe due-owners test failed.Test plan
System recap — extends existing primitives (medium risk)
Mode: recap · Base:
main@865304b0· Head:17dd55bdClassification: extends — status page CSS for mobile bar fit; inbound due-at clamp honors injected sweep clock.
Primitives touched
status-pagegetMailboxInboundDueAt/ sweep hint use injectablenowSystem map
Status worker HTML CSS plus a small inbound due-at clock consistency fix needed for CI.
Legend: green = composes · amber = extended · red = new · gray = context.
Before / after
Before:
.bar { min-width: 2px }+ gaps made the 90-day flex row wider than the card on iPhone widths. Separately, due-at clamping ignored sweepnow.After: bars may shrink (
min-width: 0),.bars/.cardclip overflow; due-at clamp uses the same clock as the sweep.Risk and invariants
nowis omitted.Docs / decisions
Summary by CodeRabbit