Skip to content

UpdateChannelFix #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
koderjoker merged 7 commits into from
Nov 29, 2023
Merged

UpdateChannelFix #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9799b40
Update Channel Tests
Darfeikus Nov 16, 2023
1c4dee8
Merge branch 'koderjoker:kj/dotNet_2023-08-01' into kj/dotNet_2023-08-01
Darfeikus Nov 21, 2023
19d774e
Update correct data type
Darfeikus Nov 23, 2023
2b61eda
Merge branch 'koderjoker:kj/dotNet_2023-08-01' into kj/dotNet_2023-08-01
Darfeikus Nov 28, 2023
ac5c70b
Merge branch 'kj/dotNet_2023-08-01' of https://github.com/Darfeikus/a…
Darfeikus Nov 28, 2023
67277f0
Update test
Darfeikus Nov 29, 2023
e3ae953
Update tag for assets after push for recordings
Darfeikus Nov 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/redis/Azure.ResourceManager.Redis/assets.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
"AssetsRepo": "Azure/azure-sdk-assets",
"AssetsRepoPrefixPath": "net",
"TagPrefix": "net/redis/Azure.ResourceManager.Redis",
"Tag": "net/redis/Azure.ResourceManager.Redis_5ce806bbfd"
"Tag": "net/redis/Azure.ResourceManager.Redis_50c384bcc2"
}
16 changes: 5 additions & 11 deletions sdk/redis/Azure.ResourceManager.Redis/tests/ScenarioTests/UpdateChannelFunctionalTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ namespace Azure.ResourceManager.Redis.Tests
public class UpdateChannelFunctionalTests : RedisManagementTestBase
{
public UpdateChannelFunctionalTests(bool isAsync)
: base(isAsync)//, RecordedTestMode.Record)
: base(isAsync) // RecordedTestMode.Record)
{
}

Expand All @@ -30,7 +30,7 @@ public async Task UpdateChannelDefaultCreationTest()
{
await SetCollectionsAsync();

var redisCacheName = Recording.GenerateAssetName("RedisBegin");
var redisCacheName = Recording.GenerateAssetName("RedisUpdateChannel");
var parameter = new RedisCreateOrUpdateContent(DefaultLocation, new RedisSku(RedisSkuName.Basic, RedisSkuFamily.BasicOrStandard, 0));

var responseCreate = (await Collection.CreateOrUpdateAsync(WaitUntil.Completed, redisCacheName, parameter)).Value;
Expand All @@ -46,19 +46,13 @@ public async Task UpdateChannelDefaultCreationTest()

var patch = new RedisPatch()
{
RedisVersion = "6.0",
UpdateChannel = UpdateChannel.Preview
};

var responseUpdate = (await responseCreate.UpdateAsync(WaitUntil.Completed, patch)).Value;

Assert.AreEqual(DefaultLocation, responseUpdate.Data.Location);
Assert.AreEqual(redisCacheName, responseUpdate.Data.Name);
Assert.AreEqual(RedisSkuName.Basic, responseUpdate.Data.Sku.Name);
Assert.AreEqual(RedisSkuFamily.BasicOrStandard, responseUpdate.Data.Sku.Family);
Assert.AreEqual(0, responseUpdate.Data.Sku.Capacity);
Assert.AreEqual(6379, responseUpdate.Data.Port);
Assert.AreEqual(6380, responseUpdate.Data.SslPort);
Assert.AreEqual(UpdateChannel.Preview, responseCreate.Data.UpdateChannel);
var response = (await ResourceGroup.GetAllRedis().GetAsync(redisCacheName)).Value;
Assert.AreEqual(UpdateChannel.Preview, response.Data.UpdateChannel);

await responseUpdate.DeleteAsync(WaitUntil.Completed);
var falseResult = (await Collection.ExistsAsync(redisCacheName)).Value;
Expand Down