Skip to content

Conversation

@HaidarZ
Copy link

@HaidarZ HaidarZ commented Sep 14, 2021

update(paired-data): replace 'data' node by 'item' node to preserve pattern and integrate better with pyxform.

Description

We’re used to the following syntax for the calculated fields , checkout the query nodes

count(instance('survey')/root/item[P_Enumerator])	

While just inside Dynamic Data Attachments the rule is changed to use the below

count(instance('survey')/root/data[P_Enumerator])	

One of the use cases is when you try to integrate data pulled from another form into any widget.

Related issues

Checkout the discussion thread on the community forum,

https://community.kobotoolbox.org/t/dynamic-data-attachments-calculation-syntax-enhancement/22580

Note

The following docs must be updated if we elevated the PR.
All the root/data expressions must be replaced by root/item

@HaidarZ HaidarZ changed the title update(paired-data): replace 'data' node by 'item' node Preserver Paired Data XPath consistency Sep 14, 2021
@HaidarZ HaidarZ changed the title Preserver Paired Data XPath consistency Preserve Paired Data XPath consistency Sep 14, 2021
@jnm
Copy link
Member

jnm commented Nov 3, 2021

@jnm jnm self-assigned this Nov 3, 2021
@jnm
Copy link
Member

jnm commented Dec 13, 2021

I believe the use of data to be consistent with XForm conventions (see discussion also linked above) and therefore decline to merge the change at this time.

I do want to express my gratitude to @HaidarZ for their interest in improving KoBoToolbox. Thank you!

@jnm jnm closed this Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants