Rework submission modal

[magicznyleszek]

Description

Reworked submission modal table for displaying responses data. Added some test for utility functions. Added _submitted_by to be displayed in table and in modal. Displaying repeat group answers in table view.

Related issues

Fixes #2651
Part of #2086
Fixes #2207
Fixes #2137
… and possibly something else 😎

[jnm]

Add a note on https://www.flowdock.com/app/kobotoolbox/support/threads/HhMbPOMNIIi_3oYVvrpBQmMAR4U when this is merged

[magicznyleszek]

@duvld fixed merge conflicts :)

[duvld]

This looks like there's a lot to check so I'll post things I find periodically here to not lose track:

It looks like this code messes up your solution to the matrix problem in #2249: (using this form)

master

2086-repeat-in-table-2

A Question Matrix type in a repeated group does not show up in table view (using this form):

It seems like when any combination of this form and other question types (so non-text) the table view goes blank again: (this is a test with the mentioned form coupled with an image upload question)

[magicznyleszek]

@duvld I pushed a fix to the broken matrix solution and as for matrix in repeat not showing up - #2086 :)

[magicznyleszek]

I also found a new problem: a survey with a matrix question inside repeat group - the data doesn't show up in the submission modal. I am fixing this now, but this will take a while, as getting the data of a repeat group is a complex task :D

[duvld]

I also found a new problem: a survey with a matrix question inside repeat group - the data doesn't show up in the submission modal. I am fixing this now, but this will take a while, as getting the data of a repeat group is a complex task :D

Can you check if this is the case for more than just matrix groups? For me, any question that is not a text question does not show up if it is in a repeat group. Godspeed!

[magicznyleszek]

For me all works just fine with: repeat_person_form.xlsx

I also pushed a fix for submission data in submission modal for matrix inside repeat not appearing.

[magicznyleszek]

Also to be clear - this PR fixes the repeat in table in a simple way, by displaying all answer in a text list. We will make a better solution in the future, but we need a design how it should look like (cc @Ig-Rebollo )

[jnm]

This had a small issue where the next/previous links did not work properly in the submission modal. That has now been fixed by bc68445#diff-f6651294b40eec7e8621989c093b76e12beefc31630df504ee4509e29ea88e16R86